Skip to content

Backport of [ui] Volumes and plugins navigation fixes, generally into release/1.9.x #24569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #24542 to be assessed for backporting due to the inclusion of the label backport/1.9.x.

The below text is copied from the body of the original PR.


Description

Mainly, this fixes a bug where navigating to a volume from the Storage page would error. This was happening because it was escaping the / after the csi/ prefix that Ember Data uses to route things. I made a similar bugfix a few months ago for plugins, but didn't think to check volumes as well

Additionally, found a few more quality-of-life around navigation within storage:

  • There was no keyboard nav for the plugins index table
  • the u keyboard shortcut would pass more info than needed to get from /volumes/:id back to /volumes (this is because it's one level more nested than most breadcrumb up-a-level nav; /storage/plugins and /storage are the same page, as far as breadcrumbs are concerned)
  • Enumerated keyboard nav to load a volume from the index page was not working, even after the above csi/ slash escaping bug was fixed; this was because the DOM event being passed to our lazyClick method (to simulate clicking on a row when you type in a keynav combo, in this case) was coming back null. There's now a defensive Elvis (?.) to return a falsy value in lazyClick.

Testing & Reproduction steps

Make some volumes/plugins and navigate around to your heart's content

Resolves #23831


Overview of commits

Copy link

Ember Test Audit comparison

release/1.9.x 862ef59 change
passes 1580 1580 0
failures 5 5 0
flaky 0 0 0
duration 000ms 000ms -000ms

@philrenaud philrenaud merged commit 155811e into release/1.9.x Dec 1, 2024
16 of 17 checks passed
@philrenaud philrenaud deleted the backport/23831-csi-volumes-cannot-be-displayed-in-nomad-18-gui/willingly-engaged-goshawk branch December 1, 2024 14:02
Copy link

github-actions bot commented Apr 1, 2025

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants