Skip to content

Conversation

@star3am
Copy link

@star3am star3am commented Oct 6, 2025

This PR adds a Dev Container to nomad repository. Enabling us to run Nomad in a Github Codespace or locally using a Dev Container

When we create a Github Codespace a new VSCode window will open
image

The Codespace will display the output of the postCreateCommand bash .devcontainer/install-nomad.sh and the postStartCommand bash -c 'nomad -version && nomad agent -dev'
image

Port 4646 Nomad UI will be available in the Ports tab
image

We can right click on that port and open it ina. new browser window
image

And we will be greeted by the Nomad UI
image

This is to my knowledge the fastest way to launch Nomad for demo or evaluation purposes live on the internet.

Thank you for this great project!

@star3am star3am requested review from a team as code owners October 6, 2025 22:52
@hashicorp-cla-app
Copy link

hashicorp-cla-app bot commented Oct 6, 2025

CLA assistant check
All committers have signed the CLA.

@hashicorp-cla-app
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @star3am! I think you may have intended to make this in a private fork? I'm not sure what it's supposed to be for. I know what GitHub codespaces are, I don't know why you'd want to add them to someone else's project if they already have a detailed contributing guide with setup. You cannot run Nomad properly this way, so it's not a particularly useful development setup.

You didn't sign the CLA so I can't really review this. But at a glance the JSON file isn't valid JSON. And Nomad already has a container image definition. Any container image would need to use that instead of a random unpinned Ubuntu image.

@tgross tgross moved this from Needs Triage to In Progress in Nomad - Community Issues Triage Oct 7, 2025
@tgross tgross self-assigned this Oct 7, 2025
@star3am star3am closed this Oct 7, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Nomad - Community Issues Triage Oct 7, 2025
@star3am
Copy link
Author

star3am commented Oct 7, 2025

Thank you for the feedback @tgross

I had some trouble getting the base image of Nomad to run, because the docker-in-docker devcontainer feature needed bash which Nomad image did not have, that is why I use the ubuntu as a base image.

I know what GitHub codespaces are, I don't know why you'd want to add them to someone else's project if they
already have a detailed contributing guide with setup.

It was intended that the dev container belongs to the nomad repository for everyone to use and expand on. and more specifically run nomad with a minimal set of features in a Github Codespace / Dev Container.

That said, I understand your feedback with regards to nomad, and I am closing this PR now.

Thank you for your time.

@star3am star3am deleted the feature/devcontainer branch October 7, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants