-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GHA Core 0.4.1 and prepare setup-packer 3.0.0 #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JenGoldstrich
changed the title
Use GHA Core 0.4.1
Use GHA Core 0.4.1 and prepare setup-packer 3.0.0
Feb 8, 2024
JenGoldstrich
commented
Feb 8, 2024
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "setup-packer", | |||
"version": "2.1.0", | |||
"version": "3.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#90 (comment) see @ahanoff's comment referencing GitHub's suggestion to make this change a major version bump in actions.
lbajolet-hashicorp
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jooola
referenced
this pull request
in hetznercloud/packer-plugin-hcloud
Feb 9, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [hashicorp/setup-packer](https://togithub.com/hashicorp/setup-packer) | action | major | `v2.0.1` -> `v3.0.0` | --- ### Release Notes <details> <summary>hashicorp/setup-packer (hashicorp/setup-packer)</summary> ### [`v3.0.0`](https://togithub.com/hashicorp/setup-packer/releases/tag/v3.0.0) [Compare Source](https://togithub.com/hashicorp/setup-packer/compare/v2.0.1...v3.0.0) #### What's Changed GitHub has previously recommended updating the major version of the action when bumping the node version due to the possibility of breaking changes with GitHub Enterprise versions potentially not having access to the newest node versions yet, because of this we have bumped the release major version to `v3.0.0` for the release of this action using node 20 - feat: update action runner to use NodeJS 20 by [@​ahanoff](https://togithub.com/ahanoff) in [https://github.com/hashicorp/setup-packer/pull/90](https://togithub.com/hashicorp/setup-packer/pull/90) - Use GHA Core 0.4.1 and prepare setup-packer 3.0.0 by [@​JenGoldstrich](https://togithub.com/JenGoldstrich) in [https://github.com/hashicorp/setup-packer/pull/92](https://togithub.com/hashicorp/setup-packer/pull/92) #### New Contributors - [@​ahanoff](https://togithub.com/ahanoff) made their first contribution in [https://github.com/hashicorp/setup-packer/pull/90](https://togithub.com/hashicorp/setup-packer/pull/90) **Full Changelog**: hashicorp/setup-packer@v2.0.1...v3.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/hetznercloud/packer-plugin-hcloud). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the version of the GHA core library that is now built using node 20
Follow up to #90