Setup performance testing framework #68
Conversation
erichaberkorn
force-pushed
the
perf-test-poc
branch
from
d3b724a to
2f628b6
Compare
| consul_ecs_image = var.consul_ecs_image | ||
| } | ||
|
|
||
| # TODO These are annoying because it frequently blocks refreshes and deletes. Is there a better way to do this? |
There was a problem hiding this comment.
Would it help to create an "allow all" intention so that it isn't dependent on the task definitions?
There was a problem hiding this comment.
I moved it there. It's more permissive, but that doesn't matter for these tests.
| source = "github.com/erichaberkorn/consul-global-scale-benchmark/infrastructure/consul-server-ec2" | ||
| project = local.name | ||
| vpc_id = module.vpc.vpc_id | ||
| subnet_ids = module.vpc.public_subnets |
There was a problem hiding this comment.
Since this is on public subnets, are the servers exposed to the public internet? And if so, are they restricted from the public internet somehow (by security group / ingress ip or etc)?
Just double checking that the Consul servers aren't subject to any extra/unknown load from "random hackers" trying to get into our EC2 instances.
There was a problem hiding this comment.
I moved the Consul servers to a private subnet
|
|
||
| tags = var.tags | ||
| capacity_provider_strategy { | ||
| capacity_provider = "FARGATE_SPOT" |
There was a problem hiding this comment.
One concern with spot capacity is it can be pulled out from under us (interrupting our tasks / etc).
Spot capacity seems useful to minimize cost while dev/testing the performance test itself, but when running the test proper, we should probably not use spot capacity to ensure consistency from test run to test run?
There was a problem hiding this comment.
I'm going to try out spot instances to see if we can save some money. If they start causing problems, we can go back to regular instances.
erichaberkorn
force-pushed
the
perf-test-poc
branch
from
95c8d6c to
a3ebfc9
Compare
erichaberkorn
force-pushed
the
perf-test-poc
branch
from
a3ebfc9 to
c46826f
Compare
erichaberkorn
force-pushed
the
perf-test-poc
branch
from
c46826f to
c402035
Compare
erichaberkorn
force-pushed
the
perf-test-poc
branch
from
0ab0a84 to
069268e
Compare
erichaberkorn
force-pushed
the
perf-test-poc
branch
from
069268e to
dc4a369
Compare
erichaberkorn
force-pushed
the
perf-test-poc
branch
from
f24f582 to
9a9a934
Compare
|
|
5 participants
This shouldn't be merged.
Changes proposed in this PR:
How I've tested this PR:
I've run a bunch of tests as described in the README.
How I expect reviewers to test this PR:
Checklist: