Update test CI workflow to run on external PRs#351
Closed
Conversation
austinvalle
reviewed
Apr 1, 2024
Member
austinvalle
left a comment
austinvalle
left a comment
There was a problem hiding this comment.
Is this PR meant to address a similar issue to the one mentioned in https://github.com/hashicorp/terraform-providers-devex-internal/issues/176 ?
If so, I'm not sure changing the target would help there 🙁
Contributor
Author
|
Ah I forgot about that issue. This issue is meant to address the test workflows not triggering at all on external PRs, but once this merges they'll still run into the configuration variables issue, so we still won't see successful runs 😞 |
Contributor
Author
|
superseded by: #526 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possibly due to a quirk with approving Github action workflow runs from external forks, the test workflow currently doesn't run on external PRs after approval but the workflow runs normally on PRs opened from local branches. Adding the
pull_requestkey should fix this.