Skip to content

TFECO-9158: Add tests for ResourceData#Identity method #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

ansgarm
Copy link
Member

@ansgarm ansgarm commented Mar 26, 2025

depends on #1453

@ansgarm ansgarm requested a review from a team as a code owner March 26, 2025 16:05
@ansgarm ansgarm changed the title Add tests for ResourceData#Identity method TFECO-9158: Add tests for ResourceData#Identity method Mar 26, 2025
@ansgarm ansgarm force-pushed the test-resource-data-identity branch from 5a77d40 to 9ea9356 Compare March 26, 2025 16:18
@ansgarm ansgarm changed the base branch from main to test-identity-data-go March 26, 2025 16:18
@ansgarm ansgarm force-pushed the test-identity-data-go branch from 8ef122c to ddb027f Compare March 26, 2025 16:19
Base automatically changed from test-identity-data-go to main March 26, 2025 16:19
@ansgarm ansgarm force-pushed the test-resource-data-identity branch from 9ea9356 to 3e094e4 Compare March 26, 2025 16:26
@ansgarm ansgarm enabled auto-merge (squash) March 26, 2025 16:27
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests! 🚀

if err != nil {
t.Fatalf("err: %s", err)
}
err = identity.Set("foo", "qux")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL, the following word after "foo", "bar", "baz" 😆

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always have to google it 😂 I only retain that it exists but not which word it was 😆

@ansgarm ansgarm merged commit 6666040 into main Mar 26, 2025
22 checks passed
@ansgarm ansgarm deleted the test-resource-data-identity branch March 26, 2025 19:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants