Skip to content

Remove Schema attribute for identity in favor of SchemaFunc #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 31, 2025
Merged

Remove Schema attribute for identity in favor of SchemaFunc #1461

merged 3 commits into from
Mar 31, 2025

Conversation

ansgarm
Copy link
Member

@ansgarm ansgarm commented Mar 27, 2025

No description provided.

@ansgarm ansgarm requested a review from a team as a code owner March 27, 2025 16:30
@ansgarm ansgarm mentioned this pull request Mar 27, 2025
Merged
austinvalle
austinvalle approved these changes Mar 31, 2025
View reviewed changes
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I updated the RFC to match 👍🏻

@ansgarm ansgarm merged commit 4186bf4 into main Mar 31, 2025
22 checks passed
@ansgarm ansgarm deleted the remove-schema-attr branch March 31, 2025 12:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@austinvalle austinvalle austinvalle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ansgarm @austinvalle