Skip to content

Conversation

tnaskali
Copy link

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

None

Description

This PR introduces a new aws_sesv2_account data source.

Relations

Relates #26796

References

https://docs.aws.amazon.com/ses/latest/APIReference-V2/API_GetAccount.html

Output from Acceptance Testing

~/IdeaProjects/terraform-provider-aws git:[f-aws-sesv2-account]
make testacc TESTARGS="-run=TestAccSESV2AccountDataSource_" PKG=sesv2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-aws-sesv2-account 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/sesv2/... -v -count 1 -parallel 20  -run=TestAccSESV2AccountDataSource_ -timeout 360m -vet=off
2025/10/14 23:12:42 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/14 23:12:42 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccSESV2AccountDataSource_default
--- PASS: TestAccSESV2AccountDataSource_default (15.42s)
=== RUN   TestAccSESV2AccountDataSource_vdmAttributes
--- PASS: TestAccSESV2AccountDataSource_vdmAttributes (17.16s)
=== RUN   TestAccSESV2AccountDataSource_suppressionAttributes
--- PASS: TestAccSESV2AccountDataSource_suppressionAttributes (16.25s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      55.169s

for the modified resource:

~/IdeaProjects/terraform-provider-aws git:[f-aws-sesv2-account]
make testacc TESTARGS="-run=TestAccSESV2AccountVDMAttributes_" PKG=sesv2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-aws-sesv2-account 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/sesv2/... -v -count 1 -parallel 20  -run=TestAccSESV2AccountVDMAttributes_ -timeout 360m -vet=off
2025/10/14 22:02:55 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/14 22:02:56 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccSESV2AccountVDMAttributes_serial
=== PAUSE TestAccSESV2AccountVDMAttributes_serial
=== CONT  TestAccSESV2AccountVDMAttributes_serial
=== RUN   TestAccSESV2AccountVDMAttributes_serial/basic
=== RUN   TestAccSESV2AccountVDMAttributes_serial/disappears
=== RUN   TestAccSESV2AccountVDMAttributes_serial/engagementMetrics
=== RUN   TestAccSESV2AccountVDMAttributes_serial/optimizedSharedDelivery
--- PASS: TestAccSESV2AccountVDMAttributes_serial (104.77s)
    --- PASS: TestAccSESV2AccountVDMAttributes_serial/basic (24.77s)
    --- PASS: TestAccSESV2AccountVDMAttributes_serial/disappears (17.13s)
    --- PASS: TestAccSESV2AccountVDMAttributes_serial/engagementMetrics (30.65s)
    --- PASS: TestAccSESV2AccountVDMAttributes_serial/optimizedSharedDelivery (32.22s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      112.391s

Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sesv2 Issues and PRs that pertain to the sesv2 service. generators Relates to code generators. size/XL Managed by automation to categorize the size of a PR. labels Oct 14, 2025
@tnaskali tnaskali marked this pull request as ready for review October 14, 2025 20:38
@tnaskali tnaskali requested a review from a team as a code owner October 14, 2025 20:38
@tnaskali
Copy link
Author

question to reviewers: most of the attributes cannot be tested at the moment because

  • either the values come from a state that isn't managed by a resource (e.g. EnforcementStatus)
  • or the resource to manage this attribute is not implemented yet (e.g. AccountDetails)

what's your recommendation for each of those cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. generators Relates to code generators. needs-triage Waiting for first response or review from a maintainer. service/sesv2 Issues and PRs that pertain to the sesv2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant