Skip to content

Conversation

cinglish
Copy link

Description

Adds support for passing role_arn to an Athena data source

Relations

Closes #41793

References

  • QuickSight Athena Parameters

    • Use the RoleArn structure to override an account-wide role for a specific Athena data source. For example, say an account administrator has turned off all Athena access with an account-wide role. The administrator can then use RoleArn to bypass the account-wide role and allow Athena access for the single Athena data source that is specified in the structure, even if the account-wide role forbidding Athena access is still active.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccQuickSightDataSource_athenaRoleARN' PKG=quicksight ACCTEST_PARALLELISM=1
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-aws_quicksight_data_source-param-athena-role-arn 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/quicksight/... -v -count 1 -parallel 1  -run=TestAccQuickSightDataSource_athenaRoleARN -timeout 360m -vet=off
2025/10/15 13:14:45 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/15 13:14:45 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccQuickSightDataSource_athenaRoleARN
=== PAUSE TestAccQuickSightDataSource_athenaRoleARN
=== CONT  TestAccQuickSightDataSource_athenaRoleARN
--- PASS: TestAccQuickSightDataSource_athenaRoleARN (39.78s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 45.189s
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema  0.469s [no tests to run]
...

Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/quicksight Issues and PRs that pertain to the quicksight service. size/L Managed by automation to categorize the size of a PR. labels Oct 15, 2025
@cinglish cinglish marked this pull request as ready for review October 15, 2025 17:34
@cinglish cinglish requested a review from a team as a code owner October 15, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. service/quicksight Issues and PRs that pertain to the quicksight service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement]: setting Athena role ARN for aws_quicksight_data_source

1 participant