-
Notifications
You must be signed in to change notification settings - Fork 9.8k
accessanalyzer: enable go-vcr
support
#44699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jar-b
wants to merge
1
commit into
main
Choose a base branch
from
f-go-vcr-accessanalyzer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```console % make testacc PKG=accessanalyzer VCR_MODE=RECORD_ONLY VCR_PATH=/tmp/accessanalyzer-vcr-testdata/ make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... make: Running acceptance tests on branch: 🌿 f-go-vcr-accessanalyzer 🌿... TF_ACC=1 go1.24.8 test ./internal/service/accessanalyzer/... -v -count 1 -parallel 20 -timeout 360m -vet=off 2025/10/17 16:06:29 Creating Terraform AWS Provider (SDKv2-style)... 2025/10/17 16:06:29 Initializing Terraform AWS Provider (SDKv2-style)... --- PASS: TestAccAccessAnalyzer_serial (266.13s) --- PASS: TestAccAccessAnalyzer_serial/Analyzer (223.38s) --- PASS: TestAccAccessAnalyzer_serial/Analyzer/accountUnusedAccess (12.09s) --- SKIP: TestAccAccessAnalyzer_serial/Analyzer/organizationInternalAccess (0.45s) --- PASS: TestAccAccessAnalyzer_serial/Analyzer/disappears (9.44s) --- PASS: TestAccAccessAnalyzer_serial/Analyzer/tags (163.76s) --- SKIP: TestAccAccessAnalyzer_serial/Analyzer/tags/ComputedTag_OnUpdate_Replace (0.00s) --- SKIP: TestAccAccessAnalyzer_serial/Analyzer/tags/IgnoreTags_Overlap_DefaultTag (0.00s) --- PASS: TestAccAccessAnalyzer_serial/Analyzer/tags/EmptyMap (16.88s) --- PASS: TestAccAccessAnalyzer_serial/Analyzer/tags/EmptyTag_OnUpdate_Add (28.97s) --- SKIP: TestAccAccessAnalyzer_serial/Analyzer/tags/DefaultTags_providerOnly (0.00s) --- SKIP: TestAccAccessAnalyzer_serial/Analyzer/tags/DefaultTags_updateToProviderOnly (0.00s) --- SKIP: TestAccAccessAnalyzer_serial/Analyzer/tags/DefaultTags_emptyResourceTag (0.00s) --- SKIP: TestAccAccessAnalyzer_serial/Analyzer/tags/DefaultTags_nullNonOverlappingResourceTag (0.00s) --- PASS: TestAccAccessAnalyzer_serial/Analyzer/tags/basic (40.18s) --- SKIP: TestAccAccessAnalyzer_serial/Analyzer/tags/DefaultTags_nonOverlapping (0.00s) --- SKIP: TestAccAccessAnalyzer_serial/Analyzer/tags/DefaultTags_updateToResourceOnly (0.00s) --- SKIP: TestAccAccessAnalyzer_serial/Analyzer/tags/ComputedTag_OnCreate (0.00s) --- PASS: TestAccAccessAnalyzer_serial/Analyzer/tags/AddOnUpdate (19.28s) --- PASS: TestAccAccessAnalyzer_serial/Analyzer/tags/EmptyTag_OnUpdate_Replace (19.83s) --- SKIP: TestAccAccessAnalyzer_serial/Analyzer/tags/DefaultTags_nullOverlappingResourceTag (0.00s) --- SKIP: TestAccAccessAnalyzer_serial/Analyzer/tags/IgnoreTags_Overlap_ResourceTag (0.00s) --- PASS: TestAccAccessAnalyzer_serial/Analyzer/tags/null (17.08s) --- PASS: TestAccAccessAnalyzer_serial/Analyzer/tags/EmptyTag_OnCreate (21.54s) --- SKIP: TestAccAccessAnalyzer_serial/Analyzer/tags/DefaultTags_overlapping (0.00s) --- SKIP: TestAccAccessAnalyzer_serial/Analyzer/tags/ComputedTag_OnUpdate_Add (0.00s) --- PASS: TestAccAccessAnalyzer_serial/Analyzer/accountInternalAccess (26.21s) --- SKIP: TestAccAccessAnalyzer_serial/Analyzer/organizationUnusedAccess (0.31s) --- SKIP: TestAccAccessAnalyzer_serial/Analyzer/type_Organization (0.30s) --- SKIP: TestAccAccessAnalyzer_serial/Analyzer/upgradeV5_95_0 (0.00s) --- PASS: TestAccAccessAnalyzer_serial/Analyzer/basic (10.83s) --- PASS: TestAccAccessAnalyzer_serial/ArchiveRule (42.75s) --- PASS: TestAccAccessAnalyzer_serial/ArchiveRule/basic (11.16s) --- PASS: TestAccAccessAnalyzer_serial/ArchiveRule/disappears (9.80s) --- PASS: TestAccAccessAnalyzer_serial/ArchiveRule/update_filters (21.79s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/accessanalyzer 273.460s ```
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
YakDriver
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
generators
Relates to code generators.
prioritized
Part of the maintainer teams immediate focus. To be addressed within the current quarter.
service/accessanalyzer
Issues and PRs that pertain to the accessanalyzer service.
size/L
Managed by automation to categorize the size of a PR.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Description
Enables
go-vcr
for theaccessanalyzer
service.Relations
Relates #25602
Relates #43717
Output from Acceptance Testing