-
Notifications
You must be signed in to change notification settings - Fork 9.8k
account: enable go-vcr
support
#44700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jar-b
wants to merge
2
commits into
main
Choose a base branch
from
f-go-vcr-account
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables `go-vcr` for the `account` service. ```console % make testacc PKG=account VCR_MODE=RECORD_ONLY VCR_PATH=/tmp/account-vcr-testdata/ make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... make: Running acceptance tests on branch: 🌿 f-go-vcr-account 🌿... TF_ACC=1 go1.24.8 test ./internal/service/account/... -v -count 1 -parallel 20 -timeout 360m -vet=off 2025/10/17 16:23:38 Creating Terraform AWS Provider (SDKv2-style)... 2025/10/17 16:23:38 Initializing Terraform AWS Provider (SDKv2-style)... === RUN TestAccAccount_serial/Region/AccountID region_test.go:69: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account. panic.go:636: provider meta not found for test TestAccAccount_serial/Region/AccountID panic.go:636: randomness source not found for test TestAccAccount_serial/Region/AccountID === RUN TestAccAccount_serial/Region/basic region_test.go:24: Step 1/3 error: Error running apply: exit status 1 Error: enabling Account Region (ap-southeast-3): operation error Account: EnableRegion, https response error StatusCode: 403, RequestID: 8bfd32c6-d078-49af-bb46-04238374fea1, AccessDeniedException: User: arn:aws:sts::<redacted>:assumed-role/<redacted> is not authorized to perform: account:EnableRegion on resource: arn:aws:account::<redacted>:account with an explicit deny in a service control policy with aws_account_region.test, on terraform_plugin_test.tf line 12, in resource "aws_account_region" "test": 12: resource "aws_account_region" "test" { panic.go:636: randomness source not found for test TestAccAccount_serial/Region/basic --- FAIL: TestAccAccount_serial (59.65s) --- PASS: TestAccAccount_serial/AlternateContact (29.70s) --- PASS: TestAccAccount_serial/AlternateContact/basic (19.58s) --- PASS: TestAccAccount_serial/AlternateContact/disappears (10.12s) --- SKIP: TestAccAccount_serial/AlternateContact/AccountID (0.00s) --- PASS: TestAccAccount_serial/PrimaryContact (26.36s) --- PASS: TestAccAccount_serial/PrimaryContact/basic (17.61s) --- PASS: TestAccAccount_serial/PrimaryContact/dataSourceBasic (8.75s) --- SKIP: TestAccAccount_serial/PrimaryContact/dataSourceAccountID (0.00s) --- FAIL: TestAccAccount_serial/Region (3.60s) --- SKIP: TestAccAccount_serial/Region/AccountID (0.00s) --- FAIL: TestAccAccount_serial/Region/basic (3.60s) FAIL FAIL github.com/hashicorp/terraform-provider-aws/internal/service/account 66.853s ```
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
YakDriver
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Introduces or discusses updates to documentation.
no-changelog-needed
Indicates that a changelog entry is not necessary
prioritized
Part of the maintainer teams immediate focus. To be addressed within the current quarter.
service/account
Issues and PRs that pertain to the account service.
size/M
Managed by automation to categorize the size of a PR.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Description
Enables
go-vcr
for theaccount
service.Relations
Relates #25602
Relates #43717
Output from Acceptance Testing