-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[Enhancement] aws_lb_listener_rule: Add transform
configuration block
#44702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tabito-hara
wants to merge
21
commits into
hashicorp:main
Choose a base branch
from
tabito-hara:f-aws_lb_listener_rule-add_transform
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Enhancement] aws_lb_listener_rule: Add transform
configuration block
#44702
tabito-hara
wants to merge
21
commits into
hashicorp:main
from
tabito-hara:f-aws_lb_listener_rule-add_transform
+649
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
5306aa8
to
03657ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Introduces or discusses updates to documentation.
enhancement
Requests to existing resources that expand the functionality or scope.
service/elbv2
Issues and PRs that pertain to the elbv2 service.
size/XL
Managed by automation to categorize the size of a PR.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Description
Add a
transform
configuration block to theaws_lb_listener_rule
resource and data source.AWS API Behavior and Provider Implementation
rewrite
field is defined as an array; however, the AWS API accepts only onerewrite
entry.MaxItems
forrewrite
is set to1
in the schema definition.ResetTransform = true
parameter must be passed to theModifyRule
API. The provider implementation uses this parameter to remove the transform configuration.rewrite.regex
andrewrite.replace
are0
and1
, respectively.These constraints are not clearly documented in the API reference but are derived from the descriptions shown in the AWS Management Console.
Documentation
transform
block is added.Relations
Closes #44675
References
API documentation
User documentation
Output from Acceptance Testing
Resource
Data Source