Skip to content

Conversation

rohank25
Copy link

@rohank25 rohank25 commented Oct 19, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

None

Description

  • Support provisioning of VPC Resource Planning IPAM Pools
  • Support provisioning of subnet cidrs from IPAM Pools
  • Graceful deletion of IPAM pool cidrs with VPC / Subnet allocations.

Notes

I faced issues when attempting to delete ipam pool cidrs (to simulate a full end-to-end configuration) because of eventual consistency issues with ipam pool allocations. My attempt at resolving this is to check which vpc / subnet allocations are within the cidr, and wait for those to be released (takes 20 mins).

I still need to fix eventual consistency issues when provisioning vpc / subnet resources across accounts / regions.

Unfortunately, running acceptance tests takes a while since IPAM is restricted to 1 per account. If you have any suggestions on how to overcome this issue, please let me know, thanks!

Relations

Closes #34615

References

Output from Acceptance Testing

WIP

% make testacc TESTS=TestAccIPAMPool_serial PKG=ec2                                  
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-ipam-subnet-reservations 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccIPAMPool_serial'  -timeout 360m -vet=off
2025/10/19 18:08:37 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/19 18:08:37 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccIPAMPool_serial
=== PAUSE TestAccIPAMPool_serial
=== CONT  TestAccIPAMPool_serial
=== RUN   TestAccIPAMPool_serial/ResourcePlanningVPC
=== RUN   TestAccIPAMPool_serial/ResourcePlanningVPC/ipv4
=== RUN   TestAccIPAMPool_serial/ResourcePlanningVPC/ipv6
=== RUN   TestAccIPAMPool_serial/ResourcePlanningVPC/sourceResourceUpdate
--- PASS: TestAccIPAMPool_serial (3459.31s)
    --- PASS: TestAccIPAMPool_serial/ResourcePlanningVPC (3459.31s)
        --- PASS: TestAccIPAMPool_serial/ResourcePlanningVPC/ipv4 (1145.17s)
        --- PASS: TestAccIPAMPool_serial/ResourcePlanningVPC/ipv6 (1148.48s)
        --- PASS: TestAccIPAMPool_serial/ResourcePlanningVPC/sourceResourceUpdate (1165.66s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        3463.725s...

Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/vpc Issues and PRs that pertain to the vpc service. size/XL Managed by automation to categorize the size of a PR. labels Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-triage Waiting for first response or review from a maintainer. service/vpc Issues and PRs that pertain to the vpc service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement]: IPAM subnet reservations

1 participant