Skip to content

Conversation

tabito-hara
Copy link
Contributor

@tabito-hara tabito-hara commented Oct 19, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

  • rds cluster storage iops change #44697 reported that when only the iops value of Provisioned IOPS storage (io1, io2) is updated, the following error occurs:

    When modifying Provisioned IOPS storage, specify a value for both allocated storage and iops.

    • As the error message indicates, when modifying parameters for Provisioned IOPS storage, both allocated_storage and iops must be provided to the API.
    • This PR fixes the issue by ensuring that both iops and allocated_storage are passed to the AWS API, even when only one of them is changed.
      • If storage_type is io1 or io2, both iops and allocated_storage are now passed to the AWS API.
  • Without this modification, the newly added acceptance tests failed with the same error.

Relations

Closes #44697

Output from Acceptance Testing

$ make testacc TESTS='TestAccRDSCluster_(allocatedStorage|iops)' PKG=rds
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 b-aws_rds_cluster-modify_provisioned_iops_storage 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSCluster_(allocatedStorage|iops)'  -timeout 360m -vet=off
2025/10/20 03:21:03 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/20 03:21:03 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccRDSCluster_allocatedStorage_io1
=== PAUSE TestAccRDSCluster_allocatedStorage_io1
=== RUN   TestAccRDSCluster_allocatedStorage_gp3
=== PAUSE TestAccRDSCluster_allocatedStorage_gp3
=== RUN   TestAccRDSCluster_iops
=== PAUSE TestAccRDSCluster_iops
=== CONT  TestAccRDSCluster_allocatedStorage_io1
=== CONT  TestAccRDSCluster_iops
=== CONT  TestAccRDSCluster_allocatedStorage_gp3
--- PASS: TestAccRDSCluster_iops (1855.16s)
--- PASS: TestAccRDSCluster_allocatedStorage_gp3 (1884.70s)
--- PASS: TestAccRDSCluster_allocatedStorage_io1 (2427.52s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        2431.880s

Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/rds Issues and PRs that pertain to the rds service. size/M Managed by automation to categorize the size of a PR. size/L Managed by automation to categorize the size of a PR. labels Oct 19, 2025
@tabito-hara tabito-hara force-pushed the b-aws_rds_cluster-modify_provisioned_iops_storage branch 2 times, most recently from 3896e1b to 60cd6e4 Compare October 19, 2025 14:25
@tabito-hara tabito-hara force-pushed the b-aws_rds_cluster-modify_provisioned_iops_storage branch from 60cd6e4 to 139918e Compare October 19, 2025 15:11
@github-actions github-actions bot added the size/S Managed by automation to categorize the size of a PR. label Oct 19, 2025
@tabito-hara tabito-hara force-pushed the b-aws_rds_cluster-modify_provisioned_iops_storage branch from 87ff43a to eedada1 Compare October 19, 2025 15:19
@tabito-hara tabito-hara marked this pull request as ready for review October 19, 2025 22:47
@tabito-hara tabito-hara requested a review from a team as a code owner October 19, 2025 22:47
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service. size/L Managed by automation to categorize the size of a PR. size/M Managed by automation to categorize the size of a PR. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rds cluster storage iops change

2 participants