Skip to content

Conversation

cschindlbeck
Copy link

@cschindlbeck cschindlbeck commented Oct 19, 2025

Description

Recent commit #44505 forces to pass

key_kms_id = null

instead of empty string / no field.
This commit should allow empty strings for this field as before.

Relations

Addresses #44648

Discussion

Alternatively, one could do the logic upwards with something like this https://github.com/cattle-ops/terraform-aws-gitlab-runner/pull/1343/files

@cschindlbeck cschindlbeck requested a review from a team as a code owner October 19, 2025 13:38
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.) size/XS Managed by automation to categorize the size of a PR. labels Oct 19, 2025
@cschindlbeck cschindlbeck force-pushed the f-aws-launch-template-allow-empty-kms-key-id branch from 292b49f to 0f1ce42 Compare October 19, 2025 13:40
@cschindlbeck cschindlbeck force-pushed the f-aws-launch-template-allow-empty-kms-key-id branch from 01a3a3d to 7733a18 Compare October 19, 2025 13:46
@justinretzolk justinretzolk added regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 20, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants