Skip to content

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Oct 20, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Enables go-vcr support for the following services with small numbers of resources/data sources:

  • autoscalingplans
  • cloudcontrol
  • cloudsearch
  • costoptimizationhub
  • customerprofiles
  • dlm
  • kinesisvideo
  • mediapackage
  • ssmquicksetup
  • swf

Relations

Relates #25602
Relates #43717
Relates #44416

Output from Acceptance Testing

See commit message bodies for the test results from each service.

jar-b added 10 commits October 20, 2025 13:17
```console
% make testacc PKG=autoscalingplans VCR_MODE=RECORD_ONLY VCR_PATH=/tmp/autoscalingplans-vcr-testdata/

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-go-vcr-autoscalingplans 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/autoscalingplans/... -v -count 1 -parallel 20   -timeout 360m -vet=off
2025/10/17 16:47:08 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/17 16:47:08 Initializing Terraform AWS Provider (SDKv2-style)...

--- PASS: TestAccAutoScalingPlansScalingPlan_basicDynamicScaling (44.27s)
=== NAME  TestAccAutoScalingPlansScalingPlan_disappears
    scaling_plan_test.go:247: stopping VCR recorder
    scaling_plan_test.go:247: persisting randomness seed
--- PASS: TestAccAutoScalingPlansScalingPlan_disappears (46.25s)
=== NAME  TestAccAutoScalingPlansScalingPlan_basicPredictiveScaling
    scaling_plan_test.go:87: stopping VCR recorder
    scaling_plan_test.go:87: persisting randomness seed
--- PASS: TestAccAutoScalingPlansScalingPlan_basicPredictiveScaling (57.44s)
=== NAME  TestAccAutoScalingPlansScalingPlan_DynamicScaling_customizedScalingMetricSpecification
    scaling_plan_test.go:271: stopping VCR recorder
    scaling_plan_test.go:271: persisting randomness seed
--- PASS: TestAccAutoScalingPlansScalingPlan_DynamicScaling_customizedScalingMetricSpecification (68.82s)
=== NAME  TestAccAutoScalingPlansScalingPlan_basicUpdate
    scaling_plan_test.go:151: stopping VCR recorder
    scaling_plan_test.go:151: persisting randomness seed
--- PASS: TestAccAutoScalingPlansScalingPlan_basicUpdate (77.91s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscalingplans	85.201s
```
```console
% make testacc PKG=cloudcontrol VCR_MODE=RECORD_ONLY VCR_PATH=/tmp/cloudcontrol-vcr-testdata/

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-go-vcr-small-pt2 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/cloudcontrol/... -v -count 1 -parallel 20   -timeout 360m -vet=off
2025/10/17 16:53:56 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/17 16:53:56 Initializing Terraform AWS Provider (SDKv2-style)...

--- PASS: TestAccCloudControlResource_DesiredState_invalidPropertyName (9.99s)
=== NAME  TestAccCloudControlResource_DesiredState_invalidPropertyValue
    resource_test.go:287: stopping VCR recorder
    resource_test.go:287: persisting randomness seed
--- PASS: TestAccCloudControlResource_DesiredState_invalidPropertyValue (11.68s)
=== NAME  TestAccCloudControlResource_resourceSchema
    resource_test.go:474: stopping VCR recorder
    resource_test.go:474: persisting randomness seed
--- PASS: TestAccCloudControlResource_resourceSchema (31.61s)
=== NAME  TestAccCloudControlResource_DesiredState_stringValueAdded
    resource_test.go:393: stopping VCR recorder
    resource_test.go:393: persisting randomness seed
--- PASS: TestAccCloudControlResource_DesiredState_stringValueAdded (39.10s)
=== NAME  TestAccCloudControlResource_basic
    resource_test.go:36: stopping VCR recorder
    resource_test.go:36: persisting randomness seed
--- PASS: TestAccCloudControlResource_basic (39.20s)
=== NAME  TestAccCloudControlResource_DesiredState_booleanValueUpdate
    resource_test.go:134: stopping VCR recorder
    resource_test.go:134: persisting randomness seed
--- PASS: TestAccCloudControlResource_DesiredState_booleanValueUpdate (39.21s)
=== NAME  TestAccCloudControlResource_DesiredState_stringValueRemoved
    resource_test.go:420: stopping VCR recorder
    resource_test.go:420: persisting randomness seed
--- PASS: TestAccCloudControlResource_DesiredState_stringValueRemoved (39.45s)
=== NAME  TestAccCloudControlResource_DesiredState_stringValueUpdate
    resource_test.go:447: stopping VCR recorder
    resource_test.go:447: persisting randomness seed
--- PASS: TestAccCloudControlResource_DesiredState_stringValueUpdate (39.57s)
=== NAME  TestAccCloudControlResource_DesiredState_booleanValueAdded
    resource_test.go:80: stopping VCR recorder
    resource_test.go:80: persisting randomness seed
--- PASS: TestAccCloudControlResource_DesiredState_booleanValueAdded (39.72s)
=== NAME  TestAccCloudControlResourceDataSource_basic
    resource_data_source_test.go:21: stopping VCR recorder
    resource_data_source_test.go:21: persisting randomness seed
--- PASS: TestAccCloudControlResourceDataSource_basic (41.38s)
=== NAME  TestAccCloudControlResource_disappears
    resource_test.go:58: stopping VCR recorder
    resource_test.go:58: persisting randomness seed
--- PASS: TestAccCloudControlResource_disappears (43.72s)
=== NAME  TestAccCloudControlResource_DesiredState_integerValueAdded
    resource_test.go:189: stopping VCR recorder
    resource_test.go:189: persisting randomness seed
--- PASS: TestAccCloudControlResource_DesiredState_integerValueAdded (45.22s)
=== NAME  TestAccCloudControlResource_DesiredState_booleanValueRemoved
    resource_test.go:107: stopping VCR recorder
    resource_test.go:107: persisting randomness seed
--- PASS: TestAccCloudControlResource_DesiredState_booleanValueRemoved (47.15s)
=== NAME  TestAccCloudControlResource_DesiredState_integerValueUpdate
    resource_test.go:243: stopping VCR recorder
    resource_test.go:243: persisting randomness seed
--- PASS: TestAccCloudControlResource_DesiredState_integerValueUpdate (50.24s)
=== NAME  TestAccCloudControlResource_DesiredState_integerValueRemoved
    resource_test.go:216: stopping VCR recorder
    resource_test.go:216: persisting randomness seed
--- PASS: TestAccCloudControlResource_DesiredState_integerValueRemoved (52.43s)
=== NAME  TestAccCloudControlResource_DesiredState_createOnly
    resource_test.go:162: stopping VCR recorder
    resource_test.go:162: persisting randomness seed
--- PASS: TestAccCloudControlResource_DesiredState_createOnly (57.23s)
=== NAME  TestAccCloudControlResource_DesiredState_objectValueRemoved
    resource_test.go:333: stopping VCR recorder
    resource_test.go:333: persisting randomness seed
--- PASS: TestAccCloudControlResource_DesiredState_objectValueRemoved (59.01s)
=== NAME  TestAccCloudControlResource_DesiredState_objectValueAdded
    resource_test.go:306: stopping VCR recorder
    resource_test.go:306: persisting randomness seed
--- PASS: TestAccCloudControlResource_DesiredState_objectValueAdded (64.23s)
=== NAME  TestAccCloudControlResource_DesiredState_objectValueUpdate
    resource_test.go:360: stopping VCR recorder
    resource_test.go:360: persisting randomness seed
--- PASS: TestAccCloudControlResource_DesiredState_objectValueUpdate (66.85s)
=== NAME  TestAccCloudControlResource_lambdaFunction
    resource_test.go:496: stopping VCR recorder
    resource_test.go:496: persisting randomness seed
--- PASS: TestAccCloudControlResource_lambdaFunction (94.81s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudcontrol	102.445s
```
```console
% make testacc PKG=cloudsearch VCR_MODE=RECORD_ONLY VCR_PATH=/tmp/cloudsearch-vcr-testdata/

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-go-vcr-small-pt2 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/cloudsearch/... -v -count 1 -parallel 20   -timeout 360m -vet=off
2025/10/20 10:32:38 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/20 10:32:38 Initializing Terraform AWS Provider (SDKv2-style)...

=== NAME  TestAccCloudSearchDomain_disappears
    domain_test.go:76: skipping tests; this AWS account does not support new CloudSearch domain creation
    panic.go:636: provider meta not found for test TestAccCloudSearchDomain_disappears
    panic.go:636: randomness source not found for test TestAccCloudSearchDomain_disappears
--- SKIP: TestAccCloudSearchDomain_disappears (0.77s)
=== NAME  TestAccCloudSearchDomain_basic
    domain_test.go:33: skipping tests; this AWS account does not support new CloudSearch domain creation
    panic.go:636: provider meta not found for test TestAccCloudSearchDomain_basic
    panic.go:636: randomness source not found for test TestAccCloudSearchDomain_basic
--- SKIP: TestAccCloudSearchDomain_basic (0.78s)
=== NAME  TestAccCloudSearchDomain_sourceFields
    domain_test.go:180: skipping tests; this AWS account does not support new CloudSearch domain creation
    panic.go:636: provider meta not found for test TestAccCloudSearchDomain_sourceFields
    panic.go:636: randomness source not found for test TestAccCloudSearchDomain_sourceFields
--- SKIP: TestAccCloudSearchDomain_sourceFields (0.78s)
=== NAME  TestAccCloudSearchDomain_indexFields
    domain_test.go:104: skipping tests; this AWS account does not support new CloudSearch domain creation
    panic.go:636: provider meta not found for test TestAccCloudSearchDomain_indexFields
    panic.go:636: randomness source not found for test TestAccCloudSearchDomain_indexFields
--- SKIP: TestAccCloudSearchDomain_indexFields (0.78s)
=== NAME  TestAccCloudSearchDomainServiceAccessPolicy_basic
    domain_service_access_policy_test.go:29: skipping tests; this AWS account does not support new CloudSearch domain creation
    panic.go:636: provider meta not found for test TestAccCloudSearchDomainServiceAccessPolicy_basic
    panic.go:636: randomness source not found for test TestAccCloudSearchDomainServiceAccessPolicy_basic
--- SKIP: TestAccCloudSearchDomainServiceAccessPolicy_basic (0.78s)
=== NAME  TestAccCloudSearchDomainServiceAccessPolicy_update
    domain_service_access_policy_test.go:60: skipping tests; this AWS account does not support new CloudSearch domain creation
    panic.go:636: provider meta not found for test TestAccCloudSearchDomainServiceAccessPolicy_update
    panic.go:636: randomness source not found for test TestAccCloudSearchDomainServiceAccessPolicy_update
--- SKIP: TestAccCloudSearchDomainServiceAccessPolicy_update (0.78s)
=== NAME  TestAccCloudSearchDomain_update
    domain_test.go:259: skipping tests; this AWS account does not support new CloudSearch domain creation
    panic.go:636: provider meta not found for test TestAccCloudSearchDomain_update
    panic.go:636: randomness source not found for test TestAccCloudSearchDomain_update
--- SKIP: TestAccCloudSearchDomain_update (0.78s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudsearch	10.945s
```
```console
% make testacc PKG=costoptimizationhub VCR_MODE=RECORD_ONLY VCR_PATH=/tmp/costoptimizationhub-vcr-testdata/

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-go-vcr-small-pt2 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/costoptimizationhub/... -v -count 1 -parallel 20   -timeout 360m -vet=off
2025/10/20 10:46:02 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/20 10:46:02 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccCostOptimizationHub_serial
=== PAUSE TestAccCostOptimizationHub_serial
=== RUN   TestEndpointConfiguration
--- PASS: TestEndpointConfiguration (0.46s)
=== CONT  TestAccCostOptimizationHub_serial
=== RUN   TestAccCostOptimizationHub_serial/EnrollmentStatus
=== RUN   TestAccCostOptimizationHub_serial/EnrollmentStatus/basic
    enrollment_status_test.go:28: stopping VCR recorder
    enrollment_status_test.go:28: randomness source not found for test TestAccCostOptimizationHub_serial/EnrollmentStatus/basic
--- PASS: TestAccCostOptimizationHub_serial/EnrollmentStatus/basic (11.20s)
=== RUN   TestAccCostOptimizationHub_serial/EnrollmentStatus/disappears
    enrollment_status_test.go:60: stopping VCR recorder
    enrollment_status_test.go:60: randomness source not found for test TestAccCostOptimizationHub_serial/EnrollmentStatus/disappears
--- PASS: TestAccCostOptimizationHub_serial/EnrollmentStatus/disappears (12.27s)
=== RUN   TestAccCostOptimizationHub_serial/EnrollmentStatus/includeMemberAccounts
    enrollment_status_test.go:92: stopping VCR recorder
    enrollment_status_test.go:92: randomness source not found for test TestAccCostOptimizationHub_serial/EnrollmentStatus/includeMemberAccounts
--- PASS: TestAccCostOptimizationHub_serial/EnrollmentStatus/includeMemberAccounts (16.26s)
=== RUN   TestAccCostOptimizationHub_serial/Preferences
=== RUN   TestAccCostOptimizationHub_serial/Preferences/basic
    preferences_test.go:27: stopping VCR recorder
    preferences_test.go:27: randomness source not found for test TestAccCostOptimizationHub_serial/Preferences/basic
--- PASS: TestAccCostOptimizationHub_serial/Preferences/basic (10.61s)
=== RUN   TestAccCostOptimizationHub_serial/Preferences/disappears
    preferences_test.go:59: stopping VCR recorder
    preferences_test.go:59: randomness source not found for test TestAccCostOptimizationHub_serial/Preferences/disappears
--- PASS: TestAccCostOptimizationHub_serial/Preferences/disappears (12.00s)
=== RUN   TestAccCostOptimizationHub_serial/Preferences/memberAccountsDiscountVisibility
    preferences_test.go:90: stopping VCR recorder
    preferences_test.go:90: randomness source not found for test TestAccCostOptimizationHub_serial/Preferences/memberAccountsDiscountVisibility
--- PASS: TestAccCostOptimizationHub_serial/Preferences/memberAccountsDiscountVisibility (10.51s)
=== RUN   TestAccCostOptimizationHub_serial/Preferences/savingsEstimationMode
    preferences_test.go:122: stopping VCR recorder
    preferences_test.go:122: randomness source not found for test TestAccCostOptimizationHub_serial/Preferences/savingsEstimationMode
--- PASS: TestAccCostOptimizationHub_serial/Preferences/savingsEstimationMode (16.40s)
--- PASS: TestAccCostOptimizationHub_serial (89.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/costoptimizationhub	96.394s
```
```console
% make testacc PKG=customerprofiles VCR_MODE=RECORD_ONLY VCR_PATH=/tmp/customerprofiles-vcr-testdata/

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-go-vcr-small-pt2 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/customerprofiles/... -v -count 1 -parallel 20   -timeout 360m -vet=off
2025/10/20 10:49:59 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/20 10:49:59 Initializing Terraform AWS Provider (SDKv2-style)...

=== NAME  TestAccCustomerProfilesDomain_disappears
    domain_test.go:203: stopping VCR recorder
    domain_test.go:203: persisting randomness seed
--- PASS: TestAccCustomerProfilesDomain_disappears (14.76s)
=== NAME  TestAccCustomerProfilesProfile_disappears
    profile_test.go:186: stopping VCR recorder
    profile_test.go:186: persisting randomness seed
--- PASS: TestAccCustomerProfilesProfile_disappears (16.53s)
=== NAME  TestAccCustomerProfilesDomain_basic
    domain_test.go:23: stopping VCR recorder
    domain_test.go:23: persisting randomness seed
--- PASS: TestAccCustomerProfilesDomain_basic (23.31s)
=== NAME  TestAccCustomerProfilesProfile_full
    profile_test.go:30: stopping VCR recorder
    profile_test.go:30: persisting randomness seed
--- PASS: TestAccCustomerProfilesProfile_full (25.87s)
=== NAME  TestAccCustomerProfilesDomain_tags
    domain_test.go:159: stopping VCR recorder
    domain_test.go:159: persisting randomness seed
--- PASS: TestAccCustomerProfilesDomain_tags (30.93s)
=== NAME  TestAccCustomerProfilesDomain_full
    domain_test.go:56: stopping VCR recorder
    domain_test.go:56: persisting randomness seed
--- PASS: TestAccCustomerProfilesDomain_full (55.60s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/customerprofiles	62.812s
```
```console
% make testacc PKG=dlm VCR_MODE=RECORD_ONLY VCR_PATH=/tmp/dlm-vcr-testdata/

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-go-vcr-small-pt2 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/dlm/... -v -count 1 -parallel 20   -timeout 360m -vet=off

20 of 21 tests passed. 1 test failed due to cross-region KMS key configuration issue (not related to go-vcr changes):
- TestAccDLMLifecyclePolicy_crossRegionCopyRule: Failed with InvalidRequestException

Passing tests (20):
- TestAccDLMLifecyclePolicy_basic
- TestAccDLMLifecyclePolicy_event
- TestAccDLMLifecyclePolicy_cron
- TestAccDLMLifecyclePolicy_scriptsAlias
- TestAccDLMLifecyclePolicy_scriptsSSMDocument
- TestAccDLMLifecyclePolicy_archiveRuleCount
- TestAccDLMLifecyclePolicy_archiveRuleInterval
- TestAccDLMLifecyclePolicy_retainInterval
- TestAccDLMLifecyclePolicy_deprecate
- TestAccDLMLifecyclePolicy_defaultPolicy
- TestAccDLMLifecyclePolicy_defaultPolicyExclusions
- TestAccDLMLifecyclePolicy_fastRestore
- TestAccDLMLifecyclePolicy_shareRule
- TestAccDLMLifecyclePolicy_parameters_instance
- TestAccDLMLifecyclePolicy_parameters_volume
- TestAccDLMLifecyclePolicy_variableTags
- TestAccDLMLifecyclePolicy_full
- TestAccDLMLifecyclePolicy_crossRegionCopyRuleImageManagement
- TestAccDLMLifecyclePolicy_tags
- TestAccDLMLifecyclePolicy_disappears

PASS (20/21 tests)
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dlm	75.911s
```
```console
% make testacc PKG=kinesisvideo VCR_MODE=RECORD_ONLY VCR_PATH=/tmp/kinesisvideo-vcr-testdata/

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-go-vcr-small-pt2 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/kinesisvideo/... -v -count 1 -parallel 20   -timeout 360m -vet=off
2025/10/20 11:09:16 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/20 11:09:16 Initializing Terraform AWS Provider (SDKv2-style)...

=== NAME  TestAccKinesisVideoStream_disappears
    stream_test.go:151: stopping VCR recorder
    stream_test.go:151: persisting randomness seed
--- PASS: TestAccKinesisVideoStream_disappears (90.82s)
=== NAME  TestAccKinesisVideoStream_basic
    stream_test.go:27: stopping VCR recorder
    stream_test.go:27: persisting randomness seed
--- PASS: TestAccKinesisVideoStream_basic (92.37s)
=== NAME  TestAccKinesisVideoStream_tags
    stream_test.go:105: stopping VCR recorder
    stream_test.go:105: persisting randomness seed
--- PASS: TestAccKinesisVideoStream_tags (106.02s)
=== NAME  TestAccKinesisVideoStream_options
    stream_test.go:65: stopping VCR recorder
    stream_test.go:65: persisting randomness seed
--- PASS: TestAccKinesisVideoStream_options (116.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kinesisvideo	123.685s
```
```console
% make testacc PKG=mediapackage VCR_MODE=RECORD_ONLY VCR_PATH=/tmp/mediapackage-vcr-testdata/

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-go-vcr-small-pt2 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/mediapackage/... -v -count 1 -parallel 20   -timeout 360m -vet=off
2025/10/20 11:20:11 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/20 11:20:11 Initializing Terraform AWS Provider (SDKv2-style)...

=== NAME  TestAccMediaPackageChannel_disappears
    channel_test.go:152: stopping VCR recorder
    channel_test.go:152: persisting randomness seed
--- PASS: TestAccMediaPackageChannel_disappears (12.85s)
=== NAME  TestAccMediaPackageChannel_basic
    channel_test.go:28: stopping VCR recorder
    channel_test.go:28: persisting randomness seed
--- PASS: TestAccMediaPackageChannel_basic (20.20s)
=== NAME  TestAccMediaPackageChannel_description
    channel_test.go:65: stopping VCR recorder
    channel_test.go:65: persisting randomness seed
--- PASS: TestAccMediaPackageChannel_description (26.75s)
=== NAME  TestAccMediaPackageChannel_tags
    channel_test.go:103: stopping VCR recorder
    channel_test.go:103: persisting randomness seed
--- PASS: TestAccMediaPackageChannel_tags (35.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mediapackage	42.416s
```
```console
% make testacc PKG=ssmquicksetup VCR_MODE=RECORD_ONLY VCR_PATH=/tmp/ssmquicksetup-vcr-testdata/
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-go-vcr-small-pt2 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/ssmquicksetup/... -v -count 1 -parallel 20   -timeout 360m -vet=off
2025/10/20 11:24:11 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/20 11:24:12 Initializing Terraform AWS Provider (SDKv2-style)...

=== CONT  TestAccSSMQuickSetupConfigurationManager_disappears
    configuration_manager_test.go:277: skipping acceptance test: required IAM role "AWS-QuickSetup-PatchPolicy-LocalAdministrationRole" not found
    panic.go:636: provider meta not found for test TestAccSSMQuickSetupConfigurationManager_disappears
--- SKIP: TestAccSSMQuickSetupConfigurationManager_disappears (0.53s)
=== NAME  TestAccSSMQuickSetupConfigurationManager_description
    configuration_manager_test.go:277: skipping acceptance test: required IAM role "AWS-QuickSetup-PatchPolicy-LocalAdministrationRole" not found
    panic.go:636: provider meta not found for test TestAccSSMQuickSetupConfigurationManager_description
--- SKIP: TestAccSSMQuickSetupConfigurationManager_description (0.54s)
=== NAME  TestAccSSMQuickSetupConfigurationManager_parameters
    configuration_manager_test.go:277: skipping acceptance test: required IAM role "AWS-QuickSetup-PatchPolicy-LocalAdministrationRole" not found
    panic.go:636: provider meta not found for test TestAccSSMQuickSetupConfigurationManager_parameters
--- SKIP: TestAccSSMQuickSetupConfigurationManager_parameters (0.55s)
=== NAME  TestAccSSMQuickSetupConfigurationManager_tags
    configuration_manager_test.go:277: skipping acceptance test: required IAM role "AWS-QuickSetup-PatchPolicy-LocalAdministrationRole" not found
    panic.go:636: provider meta not found for test TestAccSSMQuickSetupConfigurationManager_tags
--- SKIP: TestAccSSMQuickSetupConfigurationManager_tags (0.55s)
=== NAME  TestAccSSMQuickSetupConfigurationManager_basic
    configuration_manager_test.go:277: skipping acceptance test: required IAM role "AWS-QuickSetup-PatchPolicy-LocalAdministrationRole" not found
    panic.go:636: provider meta not found for test TestAccSSMQuickSetupConfigurationManager_basic
--- SKIP: TestAccSSMQuickSetupConfigurationManager_basic (0.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssmquicksetup	7.867s
```
```console
% make testacc PKG=swf VCR_MODE=RECORD_ONLY VCR_PATH=/tmp/swf-vcr-testdata/
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-go-vcr-small-pt2 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/swf/... -v -count 1 -parallel 20   -timeout 360m -vet=off
2025/10/20 13:09:40 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/20 13:09:40 Initializing Terraform AWS Provider (SDKv2-style)...

=== NAME  TestAccSWFDomain_basic
    domain_test.go:25: Environment variable SWF_DOMAIN_TESTING_ENABLED is not set. SWF limits domains per region and the API does not support deletions. Set the environment variable to any value to enable.
=== NAME  TestAccSWFDomain_description
    domain_test.go:25: Environment variable SWF_DOMAIN_TESTING_ENABLED is not set. SWF limits domains per region and the API does not support deletions. Set the environment variable to any value to enable.
=== NAME  TestAccSWFDomain_disappears
    domain_test.go:25: Environment variable SWF_DOMAIN_TESTING_ENABLED is not set. SWF limits domains per region and the API does not support deletions. Set the environment variable to any value to enable.
=== NAME  TestAccSWFDomain_tags
    domain_test.go:25: Environment variable SWF_DOMAIN_TESTING_ENABLED is not set. SWF limits domains per region and the API does not support deletions. Set the environment variable to any value to enable.
=== NAME  TestAccSWFDomain_nameGenerated
    domain_test.go:25: Environment variable SWF_DOMAIN_TESTING_ENABLED is not set. SWF limits domains per region and the API does not support deletions. Set the environment variable to any value to enable.
=== NAME  TestAccSWFDomain_namePrefix
    domain_test.go:25: Environment variable SWF_DOMAIN_TESTING_ENABLED is not set. SWF limits domains per region and the API does not support deletions. Set the environment variable to any value to enable.
=== NAME  TestAccSWFDomain_basic
    panic.go:636: provider meta not found for test TestAccSWFDomain_basic
--- SKIP: TestAccSWFDomain_basic (0.38s)
=== NAME  TestAccSWFDomain_description
    panic.go:636: provider meta not found for test TestAccSWFDomain_description
--- SKIP: TestAccSWFDomain_description (0.38s)
=== NAME  TestAccSWFDomain_disappears
    panic.go:636: provider meta not found for test TestAccSWFDomain_disappears
--- SKIP: TestAccSWFDomain_disappears (0.38s)
=== NAME  TestAccSWFDomain_tags
    panic.go:636: provider meta not found for test TestAccSWFDomain_tags
--- SKIP: TestAccSWFDomain_tags (0.38s)
=== NAME  TestAccSWFDomain_nameGenerated
    panic.go:636: provider meta not found for test TestAccSWFDomain_nameGenerated
    panic.go:636: randomness source not found for test TestAccSWFDomain_nameGenerated
--- SKIP: TestAccSWFDomain_nameGenerated (0.38s)
=== NAME  TestAccSWFDomain_namePrefix
    panic.go:636: provider meta not found for test TestAccSWFDomain_namePrefix
    panic.go:636: randomness source not found for test TestAccSWFDomain_namePrefix
--- SKIP: TestAccSWFDomain_namePrefix (0.38s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/swf	7.611s
```
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/cloudsearch Issues and PRs that pertain to the cloudsearch service. service/mediapackage Issues and PRs that pertain to the mediapackage service. service/swf Issues and PRs that pertain to the swf service. service/autoscalingplans Issues and PRs that pertain to the autoscalingplans service. service/kinesisvideo Issues and PRs that pertain to the kinesisvideo service. service/dlm Issues and PRs that pertain to the dlm service. service/cloudcontrol Issues and PRs that pertain to the cloudcontrol service. service/customerprofiles Issues and PRs that pertain to the customerprofiles service. service/costoptimizationhub Issues and PRs that pertain to the costoptimizationhub service. service/ssmquicksetup Issues and PRs that pertain to the ssmquicksetup service. size/XL Managed by automation to categorize the size of a PR. labels Oct 20, 2025
@jar-b jar-b marked this pull request as ready for review October 20, 2025 18:03
@jar-b jar-b requested a review from a team as a code owner October 20, 2025 18:03
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/autoscalingplans Issues and PRs that pertain to the autoscalingplans service. service/cloudcontrol Issues and PRs that pertain to the cloudcontrol service. service/cloudsearch Issues and PRs that pertain to the cloudsearch service. service/costoptimizationhub Issues and PRs that pertain to the costoptimizationhub service. service/customerprofiles Issues and PRs that pertain to the customerprofiles service. service/dlm Issues and PRs that pertain to the dlm service. service/kinesisvideo Issues and PRs that pertain to the kinesisvideo service. service/mediapackage Issues and PRs that pertain to the mediapackage service. service/ssmquicksetup Issues and PRs that pertain to the ssmquicksetup service. service/swf Issues and PRs that pertain to the swf service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants