Skip to content

Conversation

evgenwk
Copy link
Contributor

@evgenwk evgenwk commented Oct 13, 2025

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Added new resource and data source for Oracle Network Anchor:

internal/services/oracle/oracle_network_anchor_data_source.go
internal/services/oracle/oracle_network_anchor_resource.go

Added documentations:
website/docs/d/oracle_db_system.html.markdown
website/docs/r/oracle_db_system.html.markdown

This PR is dependent on 30796.

The PR 30796 need to be merged first.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevant documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
20251014-01-screenshot 20251014-02-screenshot 20251014-03-screenshot 20251014-04-screenshot 20251014-05-screenshot 20251015-021754-screenshot

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

closes 30840

AI Assistance Disclosure

  • AI Assisted - This contribution was made by, or with the assistance of, AI/LLMs

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@evgenwk evgenwk force-pushed the feature/oracle-network-anchor branch from 35d72a1 to 4537b1c Compare October 15, 2025 00:54
@evgenwk evgenwk changed the title Feature - oracle network anchor Oracle Network Anchor Oct 15, 2025
@evgenwk evgenwk force-pushed the feature/oracle-network-anchor branch from 4537b1c to 7042fc4 Compare October 15, 2025 01:45
@evgenwk evgenwk marked this pull request as ready for review October 15, 2025 02:19
@evgenwk evgenwk requested review from a team, WodansSon and magodo as code owners October 15, 2025 02:19
@WodansSon
Copy link
Collaborator

@evgenwk, thanks for the ping, but I cannot review this just yet since there are conflicts with your branch, could you resolve those first then I can give this a look?

@WodansSon
Copy link
Collaborator

@evgenwk, actually, would you mind breaking this up into two separate PR's one for the API upgrade and then one for the actual feature work? That would help a lot! Thanks! 🚀

@evgenwk evgenwk force-pushed the feature/oracle-network-anchor branch from 7042fc4 to 8a81fb7 Compare October 21, 2025 03:07
@evgenwk evgenwk force-pushed the feature/oracle-network-anchor branch from 8a81fb7 to 4f92007 Compare October 21, 2025 03:16
@evgenwk
Copy link
Contributor Author

evgenwk commented Oct 21, 2025

@WodansSon Thank you for your feedback.
We made the PR actual with the master.
This PR is already following the
PR with a new version: #30796.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Oracle Network Anchor Resource

2 participants