Skip to content

Conversation

ms-zhenhua
Copy link
Collaborator

@ms-zhenhua ms-zhenhua commented Oct 17, 2025

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Changes:

  • remove default value of osType to avoid backend validation error when deploying azurerm_orchestrated_virtual_machine_scale_set with specialized image

azurerm_orchestrated_virtual_machine_scale_set.res-0: Creating... ╷ │ Error: creating Orchestrated Virtual Machine Scale Set: (Name 'orchvm002' / Resource Group 'sc-development-migrate-eastasia-rg'): compute.VirtualMachineScaleSetsClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code='InvalidParameter' Message='The value 'Windows' of parameter 'osDisk.osType' is not allowed. Allowed values are: Linux.' Target='osDisk.osType' │ │ with azurerm_orchestrated_virtual_machine_scale_set.res-0, │ on main.tf line 33, in resource 'azurerm_orchestrated_virtual_machine_scale_set' 'res-0': │ 33: resource 'azurerm_orchestrated_virtual_machine_scale_set' 'res-0' { │

  • move AllowExtensionOperations into if block of OsProfile to avoid the following validation error

#30544

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevant documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
image

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_orchestrated_virtual_machine_scale_set - Fix deployment issue with specialized image

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #30544

AI Assistance Disclosure

  • AI Assisted - This contribution was made by, or with the assistance of, AI/LLMs

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@ms-zhenhua ms-zhenhua marked this pull request as ready for review October 20, 2025 05:31
@ms-zhenhua ms-zhenhua requested review from a team, WodansSon and magodo as code owners October 20, 2025 05:31
Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ms-zhenhua, thanks for the PR, I have given it a look and there are somethings that I don't understand. Maybe I don't completely understand this change, but the code does not make sense to me. Can you please respond to my comments for my edification about your changes?

OsType: pointer.To(osType),
}

if len(osType) > 0 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this, why are we now checking if it is greater than 0? I this a change in the API?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I removed the default value of osType. If os_profile is not configured, osType will be empty.

}

osType := virtualmachinescalesets.OperatingSystemTypesWindows
var osType virtualmachinescalesets.OperatingSystemTypes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be another API change? I still don't understand why this is necessary.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because for a specialized image, os_profile is not required. In this case, in original code, osType will use a default value Windows. But if the os of the specialized image is Linux, the service end will return an error 'The value 'Windows' of parameter 'osDisk.osType' is not allowed. Allowed values are: Linux.'. That's why we should not initialize osType with a default value.


virtualMachineProfile.OsProfile = vmssOsProfile
}
vmssOsProfile.AllowExtensionOperations = pointer.To(extensionOperationsEnabled)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

osType isn't used here, this doesn't seem right to me... why are we defining osType above, but we don't use it in the code anywhere?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

osType is used by ExpandOrchestratedVirtualMachineScaleSetOSDisk(v.([]interface{}), osType). If linux_configuration is set, osType is Linux. If windows_configuration is set, osType is Windows. For a specialized image, os_profile is not allowed so that osType will be empty.


if virtualMachineProfile.OsProfile == nil {
virtualMachineProfile.OsProfile = &virtualmachinescalesets.VirtualMachineScaleSetOSProfile{}
virtualMachineProfile.OsProfile = vmssOsProfile
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we blindly assigning this value without a null check?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my mistake, just added the nil check. Thanks.

`, data.RandomInteger, data.Locations.Primary, r.natgateway_template(data))
}

func (OrchestratedVirtualMachineScaleSetResource) specializedImage(data acceptance.TestData) string {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we know this a specialized image? Did you create this image earlier in your test and I just missed it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's created by SharedImageVersionResource{}.imageVersionSpecializedByVM(data)

@ms-zhenhua
Copy link
Collaborator Author

Hi @WodansSon,
Thank you for the review. I have updated the code and answered your comments. Could you please take another review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

azurerm_orchestrated_virtual_machine_scale_set Incompatible with the Specialized VM Images. OsProfile Issue.

2 participants