Add case-insensitive handling for application security group IDs #30913
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Description
This PR adds case-insensitive handling for application security group IDs in both standalone network security rules and inline security rules within network security groups. This resolves issues where Azure Resource Manager IDs with different casing cause unnecessary diffs in Terraform plans.
There is an open PR that is similar (#30821), however this PR leverages the existing
DiffSuppressFunc
pattern and adds tests.Changes:
Fixes: Case-only diffs in
azurerm_network_security_rule
andazurerm_network_security_group
resources when using application security group IDs with inconsistent casing from Azure API responses.PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
I can’t provide plan/apply logs from our internal terraform, but tests have been added:
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
BUG FIXES:
azurerm_network_security_rule
- fix case sensitivity issues withsource_application_security_group_ids
anddestination_application_security_group_ids
fields [Add case-insensitive handling for application security group IDs #30913]azurerm_network_security_group
- fix case sensitivity issues withsource_application_security_group_ids
anddestination_application_security_group_ids
fields in inlinesecurity_rule
blocks [Add case-insensitive handling for application security group IDs #30913]This is a (please select all that apply):
Related Issue(s)
Fixes #29841
AI Assistance Disclosure
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the provider.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Note
If this PR changes meaningfully during the course of review please update the title and description as required.