-
Notifications
You must be signed in to change notification settings - Fork 60
HCP Waypoint agent actions support #1304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looking good! Just a few suggestions so far (I'm still looking through a couple of parts, but wanted to give feedback while you still have some context 😅) - let me know what you think and I can take another pass when you're ready!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but one of the CI job is failing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
🛠️ Description
Added new supported action type to the
hcp_waypoint_action
resource and data source. In addition, added newhcp_waypoint_agent_group
resource and data source.As a note to reviewers, adding new test cases in the action resource and data source appears to have either caused a race condition, or made it far more likely. This appears to have been solved by making those tests in particular not parallelized like the rest of the Waypoint acceptance tests. I have not been able to reproduce the failure after making that change.
🏗️ Acceptance tests
Output from acceptance testing:
PCI review checklist
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've worked with GRC to document the impact of any changes to security controls.
Examples of changes to controls include access controls, encryption, logging, etc.
If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.