Add input variables support to Waypoint add-ons #864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paladin-devops
force-pushed
the
add-on-input-vars
branch
from
15c673e to
3b940d6
Compare
paladin-devops
force-pushed
the
rename-waypoint-templates-resource
branch
from
6b82845 to
e73e73f
Compare
HenryEstberg
approved these changes
Jun 26, 2024
| state.OutputValues, diags = types.ListValueFrom(ctx, types.ObjectType{AttrTypes: outputValue{}.attrTypes()}, ol) | ||
| } else { | ||
| state.OutputValues = types.ListNull(types.ObjectType{AttrTypes: outputValue{}.attrTypes()}) | ||
| } |
There was a problem hiding this comment.
Do you think you could explain the change here a little bit? It looks like this is to make this more readable but I want to better understand the why of this change.
There was a problem hiding this comment.
It simplifies the function to only operate on the common thing, the outputs, so we can reuse the method for both resources and data sources.
There was a problem hiding this comment.
I like how thorough the test configs that you have added are!
paladin-devops
force-pushed
the
add-on-input-vars
branch
from
3b940d6 to
74089bb
Compare
catsby
approved these changes
Jun 27, 2024
Co-authored-by: Clint <[email protected]>
jasonpilz
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
This PR enables config authors to configure their Waypoint add-ons with input variables.