feat: support Helm DeletionPropagation in Uninstall #1365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Author
|
Due to my limited knowledge of Golang and the way in which this codebase is structured/tested, I'd be happy to hand this PR over in this state to a maintainer to complete and release the work. The only elements I was unsure about is test coverage (if required) and if the Schema version needs to be updated due to this additional field. |
|
Would very much like to see this merged. |
This exposes functionality akin to the `--cascade` flag as found in the Helm CLI. Fixes hashicorp#1363
adrianmace
force-pushed
the
1363-support-deletion-propagation
branch
from
66b6462 to
943e420
Compare
Author
|
Marking this as "Ready for Review" since there does not appear to be any test coverage for existing uninstall functionality. Happy to be pointed in the right direction if tests are required here, otherwise will leave up to a reviewer to decide. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix #1363
By passing through the
DeletionPropagationvalue down to the Helm library, we can support the foreground cascading deletion feature of Kubernetes.Acceptance tests
TODO
Release Note
Release note for CHANGELOG:
References
Community Note