Skip to content

fix(kubeconfig): Enforces kubernetes context with helm release namespace #1583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(kubeconfig): Enforces kubernetes context with helm release namespace #1583

wants to merge 2 commits into from

Conversation

flavioab
Copy link

@flavioab flavioab commented Feb 6, 2025 •
edited
Loading

Description

Overriding Kubernetes context default namespace with helm release namespace.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?

Release Note

Release note for CHANGELOG:

...

References

#1582

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@flavioab flavioab requested a review from a team as a code owner February 6, 2025 18:52
@hashicorp-cla-app HashiCorp CLA App
Copy link

hashicorp-cla-app bot commented Feb 6, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@flavioab flavioab force-pushed the 1582/fix-namespace-behavior branch from 6274809 to 39b117e Compare February 6, 2025 18:52
@JaylonmcShan03
Copy link
Contributor

Hey @flavioab 👋 thanks for the fix—it makes sense to explicitly enforce the namespace override here, especially for charts with dependencies.

To help us ensure we don’t regress this behavior in the future, would you mind adding an acceptance test that reproduces the issue and validates that dependency resources get installed in the correct namespace?

Let me know if you need help mocking up a test case—happy to help!

@FredM FredM mentioned this pull request Apr 9, 2025
Open
@flavioab
Copy link
Author

flavioab commented Apr 11, 2025 •
edited
Loading

Hi @JaylonmcShan03 , finally an update on this 🙌 . I will try to increment the acceptance tests this weekend, thought about adding it before, but badly knew if this PR would be considered at some point.

@github-actions github-actions bot added size/S and removed size/XS labels Apr 12, 2025
@flavioab
Copy link
Author

@JaylonmcShan03 , acceptance tests are in place. Please feel free to make any changes on this if necessary. This test will iterate over all resources from the release and assert if the namespace is correct.

@flavioab
test(resource_helm_release_test): resources namespace validation
6ea9158 
Checks if all resources are deployed to the correct namespace.
Only Resources bound to specific namespaces are checked, the
rest is ignored.
@flavioab flavioab force-pushed the 1582/fix-namespace-behavior branch from e264ea2 to 6ea9158 Compare April 12, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
provider/v3 size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flavioab @JaylonmcShan03 @iBrandyJackson