Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging replacing secrets in values.yaml with (sensitive value) #1611

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ZeroErrors
Copy link

@ZeroErrors ZeroErrors commented Mar 27, 2025

Description

There is currently a bug in the logValues function in helm/resource_helm_release.go which causes secrets in nested objects in the values map to get replaced with (sensitive value).

To fix this I duplicated the logging code from helm/data_helm_template.go which uses json to do a deep clone of the object before replacing the secrets.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?

Release Note

Release note for CHANGELOG:

NONE

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@ZeroErrors ZeroErrors requested a review from a team as a code owner March 27, 2025 18:01
Copy link

hashicorp-cla-app bot commented Mar 27, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant