Skip to content

Conversation

aahel
Copy link

@aahel aahel commented Oct 14, 2025

Description

This pr adds support for the following missing fields in vault_azure_auth_backend_config. Api doc

  • max_retries

  • retry_delay

  • max_retry_delay

Closes VAULT-39759

Checklist

  • Added CHANGELOG entry (only for user-facing changes)
  • Acceptance tests where run against all supported Vault Versions

Output from acceptance testing:

Screenshot 2025-10-14 at 12 55 23 PM

...

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.

  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.

  • If applicable, I've documented the impact of any changes to security controls.

    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@aahel aahel marked this pull request as ready for review October 14, 2025 07:39
@aahel aahel requested review from a team as code owners October 14, 2025 07:39
@aahel aahel requested a review from tomcf-hcp October 14, 2025 07:39
@aahel aahel requested a review from Balaji2198 October 15, 2025 10:32
Balaji2198
Balaji2198 previously approved these changes Oct 15, 2025
@aahel aahel added this to the 5.4.0 milestone Oct 15, 2025
@aahel aahel requested review from fairclothjm and lursu October 15, 2025 15:53
Balaji2198
Balaji2198 previously approved these changes Oct 16, 2025
@benashz benashz self-requested a review October 16, 2025 17:08
Copy link
Collaborator

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I wonder if would be possible to replace the duration notation with seconds (int). I think that might make things a bit simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants