Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle unknown values in ephemeral resource config #35958

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Handle unknown values in ephemeral resource config #35958

wants to merge 3 commits into from
+141 −10

Commits on Nov 6, 2024

  1. avoid unknowns in OpenEphemeralResource 

    Ephemeral resources can't be opened if the configuration contains
unknown values.
    @jbardin
    jbardin committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    4a9d46f View commit details
    Browse the repository at this point in the history

  2. test for unknown ephemeral configs 

    An Ephemeral resource should not be opened at all if there are any
unknowns in the configuration.
    @jbardin
    jbardin committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    02bbd75 View commit details
    Browse the repository at this point in the history

  3. create a ui hook for unknown ephemeral config 

    This is a stopgap to give users some feedback when an ephemeral resource
contains unknowns and cannot be opened.

There is no json hook implementation so that the machine-readable spec
is not bound to the new output until further review. It doesn't really
fit with the current json ui model to have messages about what isn't
going to happen.
    @jbardin
    jbardin committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    c2a1070 View commit details
    Browse the repository at this point in the history