support setting a default audience #366
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently you can set a default `-vault-addr` and `-vault-mount` when running vault-csi-provider. This change also adds `-audience` so you can set a default audience for generated service account tokens. Otherwise, for environments that use a custom audience, it must be set in every SecretProviderClass. Since we can set a default for the mount path, it only makes sense to also be able to set a default for the audience.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently you can set a default
-vault-addrand-vault-mountwhen running vault-csi-provider. This change also adds-audienceso you can set a default audience for generated service account tokens. Otherwise, for environments that use a custom audience, it must be set in every SecretProviderClass. Since we can set a default for the mount path, it only makes sense to also be able to set a default for the audience.