Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Kubernetes-Recommended Version Label to Workloads #1064

Closed

Conversation

wyattfry
Copy link

This PR adds the Kubernetes-recommended label "app.kubernetes.io/version" to the any workloads and their Pods.
https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/#labels

The value of the version label:

The current version of the application (e.g., a SemVer 1.0, revision hash, etc.)

@wyattfry wyattfry requested a review from a team as a code owner October 24, 2024 19:59
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


Wyatt Fry seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

1 similar comment
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


Wyatt Fry seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@wyattfry wyattfry closed this Oct 24, 2024
@wyattfry wyattfry deleted the add-version-label-to-workloads branch October 25, 2024 19:39
@wyattfry
Copy link
Author

I closed this branch because I didn't have my GIthub email on the commits, so I made a new one with the right email: #1065

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant