Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow loadBalancerClass to be specified for the main vault service #763

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bbetter173
Copy link

This allows the loadBalancerClass field of the main Vault service to be configured.

@hashicorp-cla
Copy link

hashicorp-cla commented Aug 2, 2022

CLA assistant check
All committers have signed the CLA.

@timclifford
Copy link

  service:
    enabled: true

    type: LoadBalancer

    # loadBalancerClass: service.k8s.aws/nlb

    externalTrafficPolicy: Local
    port: 8200
    targetPort: 8200
    
    annotations:  
      service.beta.kubernetes.io/aws-load-balancer-scheme: internet-facing
      service.beta.kubernetes.io/aws-load-balancer-type: external
      service.beta.kubernetes.io/aws-load-balancer-ssl-ports: "8200"

When defining the above using v1.27 k8s and aws-load-balancer-controller v2.5.2 which seems to inject the loadBalancerClass field in even though its not defined in the vault service template.

image

There is an issue then when you try to rollout an update.

Service "vault" is invalid: spec.loadBalancerClass: Invalid value: "null": may not change once set

In this case you need to tear down your vault services in order to do a release which isn't ideal.

This PR will resolve that since you can define loadBalancerClass to match service.k8s.aws/nlb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants