fix(test): add securityContext for Helm test #930
Conversation
When running tests with Helm the same securityContext also should apply. Therefore this change will add the securityContext from the values file also to the Helm tests. The change will use the securityContext of the server statefulSet. This results from the fact that the same image is used in the test. Signed-off-by: Marco Lecheler <[email protected]>
|
@KhizerJaan could you please take a look here? |
templates/_helpers.tpl
Outdated
| {{/* | ||
| securityContext for the test pod template. | ||
| */}} | ||
| {{- define "server.test.securityContext.pod" -}} |
There was a problem hiding this comment.
Hello @fty4 , why do we need to define new template , as its supposed to use the securityContext of the server statefulSet. why not use "server.statefulSet.securityContext.pod" for server-test pod?
There was a problem hiding this comment.
Hi @KhizerJaan
I did that because of the indentation of the template.
But now I just added a new commit to use nindent to fix the indentation in the template files.
I hope this is the desired solution.
There was a problem hiding this comment.
@fty4 Thank you , but can you please check indentation , it does not look right for both server-statefulset and and server-test .
There was a problem hiding this comment.
When I run a diff between the templated yaml from main and after the fix I get this change:
381a382
>
414a416
>
557a560,565
>
> securityContext:
> runAsNonRoot: true
> runAsGroup: 1000
> runAsUser: 100
> fsGroup: 1000
585a594,596
>
> securityContext:
> allowPrivilegeEscalation: falseThis means the indentation should be fine.
The only issue is see here is that two new lines are beeing added...
But this is a issue in the whole chart and I am not sure how to fix this.
I guess you mean the indentation in the helpers file - I was required to remove the indentation here to later use different indentation on the statefulset and the test.
This is because both use different indentation length (6 and 10 for the statefulset and 2 and 6 for the server-test).
Do you agree, @KhizerJaan?
There was a problem hiding this comment.
Actually this does not result in a diff in the templated resources - but for sure it is better to remove them when the indentation is set in another place.
I've added commit 43ca102 for this.
|
I updated the requested changes - also I noticed that a unit-test failed (wondering why this test will not be triggered in a PR). I hope the tests implemented fit your needs. |
When running tests with Helm the same securityContext also should apply.
Therefore this change will add the securityContext from the values file also to the Helm tests.
The change will use the securityContext of the server statefulSet.
This results from the fact that the same image is used in the test.
Marco Lecheler [email protected] Mercedes-Benz Tech Innovation GmbH (ProviderInformation)