Support running the sidecar injector alongside EKS Pod Identities #793
+73
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.
We're running into an issue when using the Vault sidecar injector alongside EKS Pod Identities. Given a container in a pod with the following volumeMounts:
The
serviceaccount
function (https://github.com/hashicorp/vault-k8s/blob/main/agent-inject/agent/agent.go#L778) by default looks for any volumemount where the mountPath containsserviceAccount
, and in this scenario means that the vault sidecar injector picks theeks-pod-identity-token
volume mount when building theVAULT_CONFIG
environment var that gets injected into the pod/containers, which results in:So when the
vault-agent-init
container starts up we get the below logs:as the container is using the wrong path to load the SA token from which is used to authenticate with Vault.
In this PR I've added a new annotation
vault.hashicorp.com/agent-service-account-token-volume-name-pattern
. Similar to the existingvault.hashicorp.com/agent-service-account-token-volume-name
pattern but it allows us to pattern/glob match the volume name that contains the projected SA token. Since v1.22 Kubernetes has automatically added (enabled by default) a projected volume to all pods namedkube-api-access-<random-suffix>
which contains the SA token, ca cert and namespace. This change allows us to use this volume in conjunction with EKS Pod Identities by setting:which will assist the sidecar injector in selecting the correct volume containing the SA token