Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 1.18.x: UI LDAP Hierarchical roles #28842

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

hellobontempo
Copy link
Contributor

@hellobontempo hellobontempo commented Nov 6, 2024

Description

Backport of #28824, manual due to changes from #28432 and #28695

TODO only if you're a HashiCorp employee

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@hellobontempo hellobontempo added this to the 1.18.2 milestone Nov 6, 2024
@hellobontempo hellobontempo requested a review from a team as a code owner November 6, 2024 01:12
@hellobontempo hellobontempo added the backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent label Nov 6, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Nov 6, 2024
Copy link

github-actions bot commented Nov 6, 2024

Build Results:
All builds succeeded! ✅

Copy link

github-actions bot commented Nov 6, 2024

CI Results:
All Go tests succeeded! ✅

import { service } from '@ember/service';

import type SecretMountPath from 'vault/services/secret-mount-path';
import type StoreService from 'vault/services/store';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We updated to use a separate pagination service in 1.19 so this is the main reason for needing to manually backport.

This file should only reference this.store.lazyPaginatedQuery

@hellobontempo
Copy link
Contributor Author

✅ enterprise tests
Screenshot 2024-11-06 at 10 06 28 AM

@hellobontempo hellobontempo merged commit 5f543fb into release/1.18.x Nov 6, 2024
24 checks passed
@hellobontempo hellobontempo deleted the ui/backport-28824-1.18.x branch November 6, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent backport hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants