Backport of Solve cntrl+f issue on KVv2 JSON details and edit views into release/1.18.x #28869
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #28808 to be assessed for backporting due to the inclusion of the label backport/1.18.x.
🚨
The person who merged in the original PR is:
@Monkeychip
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Description
Address issue #28053 and closes PR #28604.
Replace the codemirror component on the KVv2 details page with the
Hds::CodeBlock
component. This solves the original issue, allowing the user to browser search the full secret while also moving us closer to HDS adoption.For the edit view, this problem is solved by correctly taking advantage of the
viewportMargin
param provided by CodeMirror.Notes:
For KVv2 only I calculate the
viewportMargin
based on the number of JSON object keys. I use the higher of the two numbers 10 or key count, but no higher than 1,000. Before we would also be using 10 (the default).For the use cases where we were passing in "Infinity" this has negative performance implications and the only upside to
usme three years ago misspellingviewportMargin
🫣.viewportmargin.mov
Overview of commits