Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Solve cntrl+f issue on KVv2 JSON details and edit views into release/1.18.x #28869

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #28808 to be assessed for backporting due to the inclusion of the label backport/1.18.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@Monkeychip
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


  • ent tests pass

Description

Address issue #28053 and closes PR #28604.

  1. Replace the codemirror component on the KVv2 details page with the Hds::CodeBlock component. This solves the original issue, allowing the user to browser search the full secret while also moving us closer to HDS adoption.

  2. For the edit view, this problem is solved by correctly taking advantage of the viewportMargin param provided by CodeMirror.

image

Notes:

  • For KVv2 only I calculate the viewportMargin based on the number of JSON object keys. I use the higher of the two numbers 10 or key count, but no higher than 1,000. Before we would also be using 10 (the default).

  • For the use cases where we were passing in "Infinity" this has negative performance implications and the only upside to us me three years ago misspelling viewportMargin 🫣.

viewportmargin.mov

Overview of commits

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

CI Results:
All Go tests succeeded! ✅

@Monkeychip Monkeychip closed this Nov 12, 2024
@Monkeychip Monkeychip deleted the backport/ui/VAULT-33227/btn-codemirror-expand/barely-amusing-blowfish branch November 12, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants