Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAULT-31749: Interceptors to reject requests from removed Raft nodes #28875

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

miagilepner
Copy link
Contributor

@miagilepner miagilepner commented Nov 11, 2024

Description

This PR adds interceptors to the request forwarding GRPC connection to include the HA node ID in requests, and check whether the node ID is present in the current configuration. If it is not, an error is returned and the client recognizes that error and shuts down, if it receives it. The error also stops any request forwarding, so that the client also receives the error.

Ent PR: https://github.com/hashicorp/vault-enterprise/pull/6959

TODO only if you're a HashiCorp employee

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Nov 11, 2024
@miagilepner miagilepner added this to the 1.19.0-rc milestone Nov 11, 2024
@miagilepner miagilepner marked this pull request as ready for review November 11, 2024 17:34
Copy link

github-actions bot commented Nov 11, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

http/handler.go Outdated Show resolved Hide resolved
vault/request_forwarding.go Outdated Show resolved Hide resolved
@miagilepner miagilepner force-pushed the miagilener/VAULT-31749-removed-interceptors branch from f582b95 to 3ac4c3a Compare November 14, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants