Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 1.18.x: UI Solve cntrl+f issue on KVv2 JSON details and edit views (#28808) #28893

Open
wants to merge 1 commit into
base: release/1.18.x
Choose a base branch
from
Open

Backport 1.18.x: UI Solve cntrl+f issue on KVv2 JSON details and edit views (#28808) #28893

wants to merge 1 commit into from
+203 −40

Commits on Nov 12, 2024

  1. Solve cntrl+f issue on KVv2 JSON details and edit views (#28808) 

    * initial changes need to add test coverage

* change icon

* replace original idea with hds::codeblock on kvv2 details view

* changelog

* fixing edit view by addressing viewportMargin

* fix failing test

* missedone

* Update 28808.txt

* Update json-editor.js

* test coverage

* update codeblock selector

* Update general-selectors.ts

* Update kv-data-fields.js

* Update ui/lib/core/addon/components/json-editor.js

Co-authored-by: claire bontempo <[email protected]>

* Update ui/lib/kv/addon/components/kv-data-fields.js

Co-authored-by: claire bontempo <[email protected]>

* update test name

* add default to modifier

---------

Co-authored-by: claire bontempo <[email protected]>
    @Monkeychip @hellobontempo
    Monkeychip and hellobontempo committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    5041e7c View commit details
    Browse the repository at this point in the history