Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.17 Manual Backport: Release notes and docs for product usage data #28917

Open
wants to merge 2 commits into
base: release/1.17.x
Choose a base branch
from
Open

1.17 Manual Backport: Release notes and docs for product usage data #28917

wants to merge 2 commits into from
+338 −30

Conversation

VioletHynes
Copy link
Contributor

@VioletHynes VioletHynes commented Nov 14, 2024 •
edited
Loading

Description

Manual backport of #28904 + #28858 for 1.17

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@VioletHynes
Product usage reporting docs (#28858)
74accb7 
* First draft of product usage reporting docs

* Table data, fix issues

* Changelog
@VioletHynes
VAULT-32201 release notes for product usage reporting (#28904)
3d14e52 
* VAULT-32201 release notes for product usage reporting

* Add note about default report months

* Better release notes
@VioletHynes VioletHynes requested a review from a team as a code owner November 14, 2024 20:43
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Nov 14, 2024
@github-actions GitHub Actions
Copy link

CI Results:
All Go tests succeeded! ✅

@github-actions GitHub Actions
Copy link

Build Results:
All builds succeeded! ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyaac divyaac Awaiting requested review from divyaac

@akshya96 akshya96 Awaiting requested review from akshya96

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@VioletHynes