UI: LDAP Hierarchical Library names#29293
Merged
hellobontempo merged 13 commits intomainfrom Jan 7, 2025
Merged
Conversation
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
hellobontempo
commented
Jan 6, 2025
| return this.store.adapterFor('ldap/role').fetchCredentials(this.backend, this.type, this.name); | ||
| return this.store | ||
| .adapterFor('ldap/role') | ||
| .fetchCredentials(this.backend, this.type, this.completeRoleName); |
Contributor
Author
There was a problem hiding this comment.
This is the bug fix when clicking the popup menu quick actions for an ldap role, such as "Get credentials"
Monkeychip
approved these changes
Jan 7, 2025
Contributor
Monkeychip
left a comment
Monkeychip
left a comment
There was a problem hiding this comment.
Approve review still stands! Excellent work on this.
Contributor
Author
|
hellobontempo
deleted the
ui/VAULT-32430/ldap-hierarchical-libaries-support
branch
6 tasks
hellobontempo
added a commit
that referenced
this pull request
Jan 22, 2025
* refactor crumbs * add subdirectory library route and hierarchical nav * update library breadcrumbs; * fix role popup menus * add getter to library model for full path * cleanup model getters * add changelog * add bug fix note * add transition after deleting * fix function definition * update adapter test * add test coverage * fix crumb typo
6 tasks
hellobontempo
added a commit
that referenced
this pull request
Jan 23, 2025
* refactor crumbs * add subdirectory library route and hierarchical nav * update library breadcrumbs; * fix role popup menus * add getter to library model for full path * cleanup model getters * add changelog * add bug fix note * add transition after deleting * fix function definition * update adapter test * add test coverage * fix crumb typo
hellobontempo
added a commit
that referenced
this pull request
Jan 23, 2025
* refactor crumbs * add subdirectory library route and hierarchical nav * update library breadcrumbs; * fix role popup menus * add getter to library model for full path * cleanup model getters * add changelog * add bug fix note * add transition after deleting * fix function definition * update adapter test * add test coverage * fix crumb typo
6 tasks
hellobontempo
added a commit
that referenced
this pull request
Jan 23, 2025
* UI: LDAP Hierarchical Library names (#29293) * refactor crumbs * add subdirectory library route and hierarchical nav * update library breadcrumbs; * fix role popup menus * add getter to library model for full path * cleanup model getters * add changelog * add bug fix note * add transition after deleting * fix function definition * update adapter test * add test coverage * fix crumb typo * fix tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds hierarchical role navigation to the UI for LDAP libariries which was added to the CLI in 1.17 (Hierarchical Paths).
Follow-on to #28824
Screen.Recording.2025-01-06.at.11.04.05.AM.mov
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.