feat(gcs): support custom universe_domain via env/config #31550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test bucket location support Small, opt-in changes: - Accept GOOGLE_UNIVERSE_DOMAIN (or config value) when building the GCS client. - Add minimal support for GOOGLE_BUCKET_LOCATION in tests to create buckets in non-standard regions. - Tests updated accordingly. Default behaviour unchanged when no universe_domain provided. Signed-off-by: Houssein Mnaouar <[email protected]>
|
@7sinStone is attempting to deploy a commit to the HashiCorp Team on Vercel. A member of the Team first needs to authorize it. |
|
|
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the
universe_domainparameter in the GCS backend.By default, the backend uses the standard
googleapis.com, but with this change, users can optionally configure a customuniverse_domainto enable Vault to work in sovereign cloud environments.Related Issue
Closes #31549
Changes Introduced
universe_domainas an optional configuration in the GCS backendBackward Compatibility
universe_domainis not set, Vault continues to usegoogleapis.comby defaultAdditional Context
This enhancement enables the use of Vault with GCP sovereign clouds, where custom API domains are required.
Signed-off-by: Houssein Mnaouar [email protected]