feat(gcp): support universe_domain for GCP kms wrappers and vault config #31554
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the
universe_domain
parameter for GCP KMS usage in Vault. When set, Vault forwards the value to the GCP KMS wrapper so the client uses a custom API domain; if not set Vault keeps usinggoogleapis.com
.Related Issue
Closes #31553
Changes Introduced
universe_domain
from Vault KMS config to the gcpckms wrapper (internalshared/configutil/kms.go
).Backward Compatibility
Default behavior unchanged: if
universe_domain
is not set, Vault continues to usegoogleapis.com
.Dependency
This PR depends on a change in
go-kms-wrapping
that addsWithUniverseDomain
. Link: go-kms-wrapping.I tested locally using a temporary
replace
in mygo.mod
. Once the wrapper PR is merged I will updatego.mod
in this branch to the released tag.Quick post-merge step (what I will do or maintainers can do):
Additional Context
Enables Vault to operate with GCP sovereign/custom endpoints by opt-in config only.
Signed-off-by: Houssein Mnaouar [email protected]