You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If merged this PR would update CSS styles for font-family, font-weightfont-size, and line-height to reference HDS tokens instead of hardcoded values or Vault foundational scss variables. This is done in order to ensure greater alignment with HDS, and improve the flexibility of typography styles in Vault to reflect any changes to HDS tokens.
The changes made should result in no significant visual changes. The values updated are a 1:1 match for values that were already present in HDS tokens.
Typography styles that did not align to any available HDS tokens were not migrated, and left untouched. These could be migrated in a future effort, but may result in visual changes to align with HDS.
As part of this migration, all references to the existing variables defined in the _font_variables.scss file have been replaced, so that file has been removed as well.
HDS tokens list
Below is a mapping of HDS tokens used in this migration and their corresponding values in Vault
Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch.
LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
Jira: If this change has an associated Jira, it's referenced either in the PR description, commit message, or branch name.
RFC: If this change has an associated RFC, please link it in the description.
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.
To https://github.com/hashicorp/vault-enterprise.git ! [rejected] copy/hashicorp/vault/31584/HDS-4976/typography-hds-alignment_HDS-5060 -> copy/hashicorp/vault/31584/HDS-4976/typography-hds-alignment_HDS-5060 (fetch first) error: failed to push some refs to 'https://github.com/hashicorp/vault-enterprise.git' hint: Updates were rejected because the remote contains work that you do not hint: have locally. This is usually caused by another repository pushing to hint: the same ref. If you want to integrate the remote changes, use hint: 'git pull' before pushing again. hint: See the 'Note about fast-forwards' in 'git push --help' for details.
To https://github.com/hashicorp/vault-enterprise.git
! [rejected] copy/hashicorp/vault/31584/HDS-4976/typography-hds-alignment_HDS-5060 -> copy/hashicorp/vault/31584/HDS-4976/typography-hds-alignment_HDS-5060 (fetch first)
error: failed to push some refs to 'https://github.com/hashicorp/vault-enterprise.git'
hint: Updates were rejected because the remote contains work that you do not
hint: have locally. This is usually caused by another repository pushing to
hint: the same ref. If you want to integrate the remote changes, use
hint: 'git pull' before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.
To https://github.com/hashicorp/vault-enterprise.git ! [rejected] copy/hashicorp/vault/31584/HDS-4976/typography-hds-alignment_HDS-5060 -> copy/hashicorp/vault/31584/HDS-4976/typography-hds-alignment_HDS-5060 (fetch first) error: failed to push some refs to 'https://github.com/hashicorp/vault-enterprise.git' hint: Updates were rejected because the remote contains work that you do not hint: have locally. This is usually caused by another repository pushing to hint: the same ref. If you want to integrate the remote changes, use hint: 'git pull' before pushing again. hint: See the 'Note about fast-forwards' in 'git push --help' for details.
To https://github.com/hashicorp/vault-enterprise.git
! [rejected] copy/hashicorp/vault/31584/HDS-4976/typography-hds-alignment_HDS-5060 -> copy/hashicorp/vault/31584/HDS-4976/typography-hds-alignment_HDS-5060 (fetch first)
error: failed to push some refs to 'https://github.com/hashicorp/vault-enterprise.git'
hint: Updates were rejected because the remote contains work that you do not
hint: have locally. This is usually caused by another repository pushing to
hint: the same ref. If you want to integrate the remote changes, use
hint: 'git pull' before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
the
hashicorp-contributed-pr
dchyun
temporarily deployed
to
community-pull-request
Description
If merged this PR would update CSS styles for
font-family,font-weightfont-size, andline-heightto reference HDS tokens instead of hardcoded values or Vault foundational scss variables. This is done in order to ensure greater alignment with HDS, and improve the flexibility of typography styles in Vault to reflect any changes to HDS tokens.The changes made should result in no significant visual changes. The values updated are a 1:1 match for values that were already present in HDS tokens.
Typography styles that did not align to any available HDS tokens were not migrated, and left untouched. These could be migrated in a future effort, but may result in visual changes to align with HDS.
As part of this migration, all references to the existing variables defined in the
_font_variables.scssfile have been replaced, so that file has been removed as well.HDS tokens list
Below is a mapping of HDS tokens used in this migration and their corresponding values in Vault
Font family
Font weight
Font size
Note: Any font-sizes set with sizing variable outside of those referenced above do not have an HDS equivalent and were left untouched.
Line height
More information on the HDS token values can be found on the HDS tokens docs page
External Links
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch.PCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.