Skip to content

fix check invalidKeyUsages slice emptiness #31599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dselyuzhitskiy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix check invalidKeyUsages slice emptiness #31599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion builtin/logical/pki/path_root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,7 +693,7 @@ func validateCaKeyUsages(keyUsages []string) error {
invalidKeyUsages = append(invalidKeyUsages, fmt.Sprintf("unrecognized key usage %s", usage))
}
}
if invalidKeyUsages != nil {
if len(invalidKeyUsages) > 0 {
return errors.New(strings.Join(invalidKeyUsages, "; "))
}
return nil
Expand Down
3 changes: 3 additions & 0 deletions changelog/31597.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
builtin/logical/pki: don't return error for valid CA Key Usages on validation
```