Skip to content

H-5023: Add critical thinking and feedback section in CLAUDE.md #7668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

TimDiekmann
Copy link
Member

🌟 What is the purpose of this PR?

AI tends to agree to the user regardless of what they say

You're absolutely right, …

A small section in CLAUDE.md should help.

@TimDiekmann TimDiekmann self-assigned this Jul 21, 2025
@TimDiekmann TimDiekmann enabled auto-merge July 21, 2025 10:02
@TimDiekmann TimDiekmann requested a review from Copilot July 21, 2025 10:02
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new section to the CLAUDE.md file encouraging critical thinking and challenging user suggestions instead of automatically agreeing with them. The change addresses the issue of AI assistants being overly agreeable by providing specific guidance on how to question assumptions and offer alternative perspectives.

  • Adds a "Critical Thinking and Feedback" section with guidelines for challenging user suggestions
  • Includes example behaviors showing preferred responses versus automatic agreement
  • Positions this guidance prominently at the top of the development guide

@github-actions github-actions bot added the area/infra Relates to version control, CI, CD or IaC (area) label Jul 21, 2025
@TimDiekmann TimDiekmann requested a review from vilkinsons July 21, 2025 10:03
@TimDiekmann TimDiekmann changed the title H-5023: Add section in CLAUDE.md to question the users suggestion H-5023: Add critical thinking and feedback section in CLAUDE.md Jul 21, 2025
Copy link
Contributor

Benchmark results

@rust/hash-graph-benches – Integrations

representative_read_entity

Function Value Mean Flame graphs
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1 $$29.9 \mathrm{ms} \pm 283 \mathrm{μs}\left({\color{lightgreen}-25.533 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1 $$29.3 \mathrm{ms} \pm 288 \mathrm{μs}\left({\color{gray}-4.033 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1 $$29.9 \mathrm{ms} \pm 291 \mathrm{μs}\left({\color{lightgreen}-23.774 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1 $$29.6 \mathrm{ms} \pm 299 \mathrm{μs}\left({\color{gray}-0.245 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1 $$30.0 \mathrm{ms} \pm 304 \mathrm{μs}\left({\color{gray}-2.136 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1 $$29.0 \mathrm{ms} \pm 275 \mathrm{μs}\left({\color{gray}0.247 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1 $$30.2 \mathrm{ms} \pm 306 \mathrm{μs}\left({\color{gray}0.960 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2 $$29.9 \mathrm{ms} \pm 280 \mathrm{μs}\left({\color{lightgreen}-23.085 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1 $$29.8 \mathrm{ms} \pm 261 \mathrm{μs}\left({\color{lightgreen}-26.023 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_linkless

Function Value Mean Flame graphs
entity_by_id 10000 entities $$22.0 \mathrm{ms} \pm 191 \mathrm{μs}\left({\color{gray}-1.353 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1000 entities $$15.7 \mathrm{ms} \pm 68.8 \mathrm{μs}\left({\color{red}7.81 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$15.1 \mathrm{ms} \pm 82.5 \mathrm{μs}\left({\color{gray}1.54 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$15.2 \mathrm{ms} \pm 68.6 \mathrm{μs}\left({\color{gray}1.34 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 100 entities $$15.2 \mathrm{ms} \pm 67.3 \mathrm{μs}\left({\color{red}9.13 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_one_depth

Function Value Mean Flame graphs
entity_by_id 1 entities $$58.0 \mathrm{ms} \pm 325 \mathrm{μs}\left({\color{gray}2.13 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 50 entities $$374 \mathrm{ms} \pm 1.64 \mathrm{ms}\left({\color{lightgreen}-93.080 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$107 \mathrm{ms} \pm 448 \mathrm{μs}\left({\color{gray}2.06 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$258 \mathrm{ms} \pm 1.26 \mathrm{ms}\left({\color{gray}-0.383 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$69.9 \mathrm{ms} \pm 283 \mathrm{μs}\left({\color{gray}2.68 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_zero_depth

Function Value Mean Flame graphs
entity_by_id 1 entities $$14.9 \mathrm{ms} \pm 99.1 \mathrm{μs}\left({\color{gray}-2.998 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 50 entities $$18.0 \mathrm{ms} \pm 90.8 \mathrm{μs}\left({\color{gray}1.35 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$15.5 \mathrm{ms} \pm 62.1 \mathrm{μs}\left({\color{gray}-4.037 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$17.5 \mathrm{ms} \pm 111 \mathrm{μs}\left({\color{red}9.69 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$15.3 \mathrm{ms} \pm 100 \mathrm{μs}\left({\color{gray}-1.229 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity_type

Function Value Mean Flame graphs
get_entity_type_by_id Account ID: bf5a9ef5-dc3b-43cf-a291-6210c0321eba $$8.65 \mathrm{ms} \pm 38.4 \mathrm{μs}\left({\color{gray}-0.508 \mathrm{\%}}\right) $$ Flame Graph

representative_read_multiple_entities

Function Value Mean Flame graphs
link_by_source_by_property depths: DT=2, PT=2, ET=2, E=2 $$266 \mathrm{ms} \pm 900 \mathrm{μs}\left({\color{gray}-1.002 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=2 $$236 \mathrm{ms} \pm 1.51 \mathrm{ms}\left({\color{gray}-3.251 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=255, PT=255, ET=255, E=255 $$285 \mathrm{ms} \pm 1.78 \mathrm{ms}\left({\color{gray}-1.359 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=0 $$192 \mathrm{ms} \pm 1.68 \mathrm{ms}\left({\color{gray}-3.127 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=2, E=2 $$247 \mathrm{ms} \pm 961 \mathrm{μs}\left({\color{gray}-3.566 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=2, ET=2, E=2 $$258 \mathrm{ms} \pm 1.37 \mathrm{ms}\left({\color{gray}-2.467 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=2, PT=2, ET=2, E=2 $$130 \mathrm{ms} \pm 542 \mathrm{μs}\left({\color{gray}-2.142 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=2 $$106 \mathrm{ms} \pm 674 \mathrm{μs}\left({\color{gray}-4.685 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=255, PT=255, ET=255, E=255 $$150 \mathrm{ms} \pm 750 \mathrm{μs}\left({\color{gray}-1.284 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=0 $$96.3 \mathrm{ms} \pm 536 \mathrm{μs}\left({\color{lightgreen}-6.690 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=2, E=2 $$116 \mathrm{ms} \pm 567 \mathrm{μs}\left({\color{gray}-3.491 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=2, ET=2, E=2 $$123 \mathrm{ms} \pm 546 \mathrm{μs}\left({\color{gray}-3.185 \mathrm{\%}}\right) $$ Flame Graph

@TimDiekmann TimDiekmann added this pull request to the merge queue Jul 21, 2025
Merged via the queue into main with commit 9a50915 Jul 21, 2025
159 checks passed
@TimDiekmann TimDiekmann deleted the t/h-5023-add-section-in-claudemd-to-question-the-users-suggestion branch July 21, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra Relates to version control, CI, CD or IaC (area)
Development

Successfully merging this pull request may close these issues.

2 participants