-
Notifications
You must be signed in to change notification settings - Fork 112
fix: adjust post html markup for safari's reader #831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
df46091
to
4de90da
Compare
4de90da
to
3197c40
Compare
mode * rework html markup by removing extra section tag and replacing h1 with header * fixes css that was broken by changes to structure * add structured data so browser can infer things like markup, type, title, and author
3197c40
to
7ac3e55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jwworth This should fix the reader mode issue. Could I trouble you for a quick once over on staging? If you need credentials, I can provide those in the alumni slack. |
I did a final pre-deploy test in staging today and there's something not quite right. I'm having a hard time telling if it's this change or a recent change to iOS/Safari. I could definitely use some help here. On Mobile Safari (iOS 18.4.1), the Reader Mode option is no longer showing in the toolbar. There is an option to automatically enable Reader Mode on certain webpages. Toggling this for TIL and refreshing the page does nothing. Still can't see anything in Reader Mode. However, if I scroll to the bottom of the feed and click "Older TILs", Reader Mode does become available, but only for a single, large-ish, TIL in the feed - "Delete a Command from ZSH history". On Desktop Safari (Sequoia 15.3.2), toggling Reader Mode only summarizes 1 TIL in the feed, ALL Caps SQL, which is another longer winded TIL. Some notes -
|
fixes #830