Skip to content

fix: adjust post html markup for safari's reader #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

avogel3
Copy link
Member

@avogel3 avogel3 commented Mar 3, 2025

  • rework html markup by removing extra section tag and replacing h1 with header
  • fixes css that was broken by changes to structure
  • add structured data so browser can infer things like markup, type, title, and author
  • Test and Verify on Staging

fixes #830

mode

* rework html markup by removing extra section tag and replacing h1 with header
* fixes css that was broken by changes to structure
* add structured data so browser can infer things like markup, type,
  title, and author
@avogel3 avogel3 force-pushed the fix/safari-reader-mode branch from 3197c40 to 7ac3e55 Compare March 10, 2025 16:15
@avogel3 avogel3 requested a review from vnegrisolo March 12, 2025 17:03
@avogel3 avogel3 added bug elixir Pull requests that update Elixir code labels Mar 12, 2025
Copy link
Member

@vnegrisolo vnegrisolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avogel3
Copy link
Member Author

avogel3 commented Mar 14, 2025

@jwworth This should fix the reader mode issue. Could I trouble you for a quick once over on staging? If you need credentials, I can provide those in the alumni slack.

@avogel3
Copy link
Member Author

avogel3 commented May 4, 2025

I did a final pre-deploy test in staging today and there's something not quite right. I'm having a hard time telling if it's this change or a recent change to iOS/Safari. I could definitely use some help here.

On Mobile Safari (iOS 18.4.1), the Reader Mode option is no longer showing in the toolbar. There is an option to automatically enable Reader Mode on certain webpages. Toggling this for TIL and refreshing the page does nothing. Still can't see anything in Reader Mode. However, if I scroll to the bottom of the feed and click "Older TILs", Reader Mode does become available, but only for a single, large-ish, TIL in the feed - "Delete a Command from ZSH history".

On Desktop Safari (Sequoia 15.3.2), toggling Reader Mode only summarizes 1 TIL in the feed, ALL Caps SQL, which is another longer winded TIL.

Some notes -

  • Some google search results suggested long pressing the "square with 2 lines" icon in the search bar(mobile), but this does nothing.
  • Another thing that I found through some various posts on reddit and the apple community forums - Apple may have implemented a change to Reader Mode in the last 6-8 months that requires content to hit a certain threshold before it the Reader Mode option becomes available. If this is the case, we may not be a "reader mode friendly" website anymore. Either way, this needs a bit more investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug elixir Pull requests that update Elixir code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reader Mode Misses Content
3 participants