Ipv6 support in buildServerUrl() #1076
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding loops to scan through lines to support importing hashes longer then 1024 bytes
|
There is something wrong with the pr. you are also including some other commits it seems. |
|
ah yes i see its because i forked the main branch and i made a pull request for the dev branch and apparently the main branch has more commits than the dev branch. I could revert the commits but i dont know if it really matters because with this pull request the dev branch will be up to date again with the main branch. |
|
Can we check an merge this PR or do you want to revert the changes made for HashLists? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #725
The current code didn't work in case of an ipv6 address. This is because the host name got parsed by using strpos($hostname, ":"). this goes perfectly fine for an ipv4 address. But when you have an ipv6 address that already contains multiple ":" characters this goes wrong. For example http://[201:a373:f940:2421:b2f2:6a91:86b7:5628]/api/server.php would become http://[201/api/server.php. I fixed it by using strrpos when the server is not at port 80 or 433. This way the last occurrence of ":" will be used which splits the hostname of the port.