Skip to content

gunfold and gfoldl implementations for instance Data UUID #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ddssff
Copy link

@ddssff ddssff commented Jun 7, 2018

I ran into a situation where a problem I was diagnosing was masked by this call to error "gunfold". This seems like a harmless enhancement to the instance, unless I'm mistaken. These definitions are adapted from those generated by DeriveDataTypeable.

@ddssff
Copy link
Author

ddssff commented Jun 7, 2018

I suppose this will leak implementation details...

λ> fmap gshow (fromString "ed41b3df-e0e3-4b95-bcf7-6630691639b7")
Just "(ed41b3df-e0e3-4b95-bcf7-6630691639b7 (17096143434607184789) (13616464356485511607))"

@phadej
Copy link
Collaborator

phadej commented Feb 16, 2021

As Data instance is manually written, as far as we keep the "fake constructor" stable, it's fine to have it. However what representation we should expose? Related to #33, they should be the same.

@ddssff
Copy link
Author

ddssff commented Feb 17, 2021

I will consider this and get back to you in 2024. :-)

@ddssff ddssff closed this Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants