Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add till' #115

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Data/Attoparsec/ByteString.hs
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,15 @@ module Data.Attoparsec.ByteString
, many1'
, manyTill
, manyTill'
, till'
, sepBy
, sepBy'
, sepBy1
, sepBy1'
, skipMany
, skipMany1
, skipTill
, skipTill'
, eitherP
, I.match
-- * State observation and manipulation functions
Expand Down
3 changes: 3 additions & 0 deletions Data/Attoparsec/ByteString/Char8.hs
Original file line number Diff line number Diff line change
Expand Up @@ -114,12 +114,15 @@ module Data.Attoparsec.ByteString.Char8
, many1'
, manyTill
, manyTill'
, till'
, sepBy
, sepBy'
, sepBy1
, sepBy1'
, skipMany
, skipMany1
, skipTill
, skipTill'
, eitherP
, I.match
-- * State observation and manipulation functions
Expand Down
46 changes: 45 additions & 1 deletion Data/Attoparsec/Combinator.hs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{-# LANGUAGE BangPatterns, CPP #-}
{-# LANGUAGE BangPatterns, CPP, TupleSections #-}
#if __GLASGOW_HASKELL__ >= 702
{-# LANGUAGE Trustworthy #-} -- Imports internal modules
#endif
Expand All @@ -25,12 +25,15 @@ module Data.Attoparsec.Combinator
, many1'
, manyTill
, manyTill'
, till'
, sepBy
, sepBy'
, sepBy1
, sepBy1'
, skipMany
, skipMany1
, skipTill
, skipTill'
, eitherP
, feed
, satisfyElem
Expand Down Expand Up @@ -214,6 +217,20 @@ manyTill' p end = scan
{-# SPECIALIZE manyTill' :: Parser Text a -> Parser Text b -> Parser Text [a] #-}
{-# SPECIALIZE manyTill' :: Z.Parser a -> Z.Parser b -> Z.Parser [a] #-}

-- | @till' p end@ applies action @p@ /zero/ or more times until
-- action @end@ succeeds, and returns a tuple of the list of
-- values returned by @p@, and @end@.
--
-- The value returned by @p@ is forced to WHNF.
till' :: (MonadPlus m) => m a -> m b -> m ([a], b)
till' p end = mapFst ($ []) <$> scan (id, undefined)
where scan (fp, e) = fmap (fp,) end `mplus` do !a <- p; scan (fp . (a:), e)
mapFst f (x, y) = (f x, y)
{-# SPECIALIZE till' :: Parser ByteString a -> Parser ByteString b
-> Parser ByteString ([a], b) #-}
{-# SPECIALIZE till' :: Parser Text a -> Parser Text b -> Parser Text ([a], b) #-}
{-# SPECIALIZE till' :: Z.Parser a -> Z.Parser b -> Z.Parser ([a], b) #-}

-- | Skip zero or more instances of an action.
skipMany :: Alternative f => f a -> f ()
skipMany p = scan
Expand All @@ -229,6 +246,33 @@ skipMany1 p = p *> skipMany p
{-# SPECIALIZE skipMany1 :: Parser Text a -> Parser Text () #-}
{-# SPECIALIZE skipMany1 :: Z.Parser a -> Z.Parser () #-}

-- | @skipTill p end@ applies action @p@ /zero/ or more times until
-- action @end@ succeeds, and returns the value returned by @end@.
-- This complements @manyTill@ and can be used to find a specific
-- pattern in a text.
skipTill :: Alternative f => f a -> f b -> f b
skipTill p end = scan
where scan = end <|> (p *> scan)
{-# SPECIALIZE skipTill :: Parser ByteString a -> Parser ByteString b
-> Parser ByteString b #-}
{-# SPECIALIZE skipTill :: Parser Text a -> Parser Text b -> Parser Text b #-}
{-# SPECIALIZE skipTill :: Z.Parser a -> Z.Parser b -> Z.Parser b #-}

-- | @skipTill' p end@ applies action @p@ /zero/ or more times until
-- action @end@ succeeds, and returns the value returned by @end@.
-- This complements @manyTill'@ and can be used to find a specific
-- pattern in a text.
--
-- The value returned by @p@ is forced to WHNF.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this forcing done?

skipTill' :: (MonadPlus m) => m a -> m b -> m b
skipTill' p end = scan
where scan = end `mplus` (p !*> scan)
(!*>) a0 a1 = fmap (\(!a) -> a) a0 *> a1
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bgamari This should do it, right?

{-# SPECIALIZE skipTill' :: Parser ByteString a -> Parser ByteString b
-> Parser ByteString b #-}
{-# SPECIALIZE skipTill' :: Parser Text a -> Parser Text b -> Parser Text b #-}
{-# SPECIALIZE skipTill' :: Z.Parser a -> Z.Parser b -> Z.Parser b #-}

-- | Apply the given action repeatedly, returning every result.
count :: Monad m => Int -> m a -> m [a]
count n p = sequence (replicate n p)
Expand Down
3 changes: 3 additions & 0 deletions Data/Attoparsec/Text.hs
Original file line number Diff line number Diff line change
Expand Up @@ -113,12 +113,15 @@ module Data.Attoparsec.Text
, many1'
, manyTill
, manyTill'
, till'
, sepBy
, sepBy'
, sepBy1
, sepBy1'
, skipMany
, skipMany1
, skipTill
, skipTill'
, eitherP
, I.match
-- * State observation and manipulation functions
Expand Down