New API to convert directly between lazy and short bytestrings#619
Merged
Bodigrim merged 2 commits intohaskell:masterfrom Sep 12, 2025
Merged
New API to convert directly between lazy and short bytestrings#619Bodigrim merged 2 commits intohaskell:masterfrom
Bodigrim merged 2 commits intohaskell:masterfrom
Conversation
Bodigrim
reviewed
Oct 10, 2023
vdukhovni
force-pushed
the
lazy-from-to-short
branch
from
0bbd297 to
0158b8c
Compare
Bodigrim
approved these changes
Oct 11, 2023
clyring
reviewed
Oct 16, 2023
Member
clyring
left a comment
clyring
left a comment
There was a problem hiding this comment.
I don't know what's going on with CI.
I don't mind this style of concatenation seen in lazyToShort, but will point out that every other concatenation-like function in the package calculates the total length first and allocates just one buffer.
vdukhovni
force-pushed
the
lazy-from-to-short
branch
from
0158b8c to
25792f4
Compare
vdukhovni
force-pushed
the
lazy-from-to-short
branch
from
25792f4 to
353ee18
Compare
Contributor
Author
|
@clyring I believe your concerns have now been addressed. Please let me know if there are any remaining issues. |
clyring
reviewed
Sep 2, 2025
Matthew Craven review fixes
Contributor
Author
clyring
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.