Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document program-options #10173

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Conversation

jasagredo
Copy link
Collaborator

@jasagredo jasagredo commented Jul 3, 2024

@jasagredo
Copy link
Collaborator Author

I'm not really sure if what I did with CabalConfigSection is right, I just mimicked what was there for pkg-section. And also I saw that there were no other cfg-section declarations so nothing broke.

@jasagredo jasagredo force-pushed the js/document-program-options branch from 5bc829e to 876166e Compare July 5, 2024 12:02
@jasagredo jasagredo requested a review from geekosaur July 5, 2024 12:08
@jasagredo
Copy link
Collaborator Author

@geekosaur I re-requested the review because I added PROG-options documentation in the configuration chapter.

doc/cabal-package-description-file.rst Show resolved Hide resolved
doc/config.rst Outdated Show resolved Hide resolved
doc/config.rst Show resolved Hide resolved
doc/config.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@geekosaur geekosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits.

doc/config.rst Outdated Show resolved Hide resolved
doc/config.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@andreabedini andreabedini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@jasagredo jasagredo added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Jul 16, 2024
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Jul 18, 2024
@Mikolaj Mikolaj force-pushed the js/document-program-options branch from bdc392d to 379f400 Compare July 18, 2024 11:07
@mergify mergify bot merged commit 174721d into haskell:master Jul 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants