Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test on Tier 2 platforms and make a prerelease for them #10372

Closed
wants to merge 1 commit into from

Conversation

geekosaur
Copy link
Collaborator

@geekosaur geekosaur commented Sep 18, 2024

This runs overnight, so it doesn't bog down PRs.

I'm not sure the prerelease part will work; we'll just have to see.

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • [ ] Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions). scheduled workflows only run on master

Depends-on: #10363

@geekosaur
Copy link
Collaborator Author

About the only way this can be tested is to commit it, since it has to be on master and has to be scheduled by GHA.

@geekosaur geekosaur force-pushed the intel-macs-overnight branch 2 times, most recently from f3699dd to 85170b5 Compare September 18, 2024 03:46
@ulysses4ever
Copy link
Collaborator

What about the main validate workflow: should it avoid testing these now?

@geekosaur
Copy link
Collaborator Author

The whole point of this PR is that when #10363 (which is marked above as a Depends-on:) lands, Intel Macs won't be tested or prereleased at all.

@ulysses4ever
Copy link
Collaborator

Good!

@geekosaur
Copy link
Collaborator Author

There's a significant question here: how much of the validate workflow do we want to run? It could be argued that full validation on AArch64 is good enough, but it could also be argued that that's inviting bitrot. (If we want to run most or all of the validate workflow, I'll want to split that into reusable components that can be shared between this job and the main workflow.)

@geekosaur geekosaur force-pushed the intel-macs-overnight branch 2 times, most recently from bfc3778 to 17072be Compare October 1, 2024 03:19
@geekosaur geekosaur closed this Oct 1, 2024
@ulysses4ever
Copy link
Collaborator

For posterity, it'd be good to comment why this wasn't merged

@geekosaur
Copy link
Collaborator Author

No, actually, I don't think so.

@geekosaur geekosaur reopened this Oct 3, 2024
@geekosaur geekosaur changed the title test on Intel Macs and make a prerelease for them test on Tier 2 platforms and make a prerelease for them Oct 3, 2024
@geekosaur
Copy link
Collaborator Author

Reflavoring in terms of tier 2 platforms, several of which are built as part of a release but never validated. The hard part here will be fitting FreeBSD into it, since the release build is done on CircleCI instead of GitLab. I will probably take that from #9437, along with the target platform list (I expect, for example, at least one i386 build).

@geekosaur
Copy link
Collaborator Author

geekosaur commented Oct 4, 2024

Some additional notes:

  • I want to split validate.yml up into multiple local actions, so they can be shared between that and this. That will be a separate PR and will not change behavior.
  • As above, we need to decide which checks will be done here.
  • We may want to also think about splitting the validate.yml checks into PR and merge checks, the latter being more complete. That would also be a separate PR, and would depend on the first one.

This runs overnight, so it doesn't bog down PRs.

I'm not sure the prerelease part will work; we'll just have to see.
@geekosaur
Copy link
Collaborator Author

Superseded by #10503.

@geekosaur geekosaur closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants