-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport #10320: Convert validate.sh
to a Haskell script
#10490
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This disentangles the utility boilerplate from the validation logic, making the `Main.hs` module much easier to read and modify. (cherry picked from commit 43a3975)
(cherry picked from commit e257591)
(cherry picked from commit 96d6ad5)
(cherry picked from commit 9f5d90f)
(cherry picked from commit a10a2a3)
(cherry picked from commit 37cfe85)
(cherry picked from commit 92613f0)
This seems to fix an error where `long-tests` isn't built? (cherry picked from commit d208282)
(cherry picked from commit bae200a)
(cherry picked from commit 1900d5e)
(cherry picked from commit 30f0faa)
Cherry-pick of 582a5c7 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
2 tasks
geekosaur
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10317.
A Haskell script will be easier to maintain and expand than the existing Bash script.
This also adds a
--pattern PATTERN
option which lets you filter tests across all test suites.I've kept the new script's behavior as close to the old script's behavior as possible, to reduce design discussion on this PR.
TODO
cabal-validate/README.md
to make it obvious where to look for logic and how to interact with the programFuture work
tasty
args (currently--hide-successes
)--list-steps
only lists the steps that are enabled with the given command-line options, not all possible steps;./validate.sh --list-steps
and./validate.sh --list-steps --run-cli-suite
give different results! (This is an existing bug in the old script.)lib-tests
step runs five different test suites, making it take much longer than necessary to reproduce test failures.--help
output could use some love; it wasn't very clear to me what various commands do.--keep-going
mode to ignore failures and continue executing tests/suites.This is an automatic backport of pull request Convert
validate.sh
to a Haskell script #10320 done by Mergify.